Skip to content

Expand free alias types when computing implied outlives-bounds - #141007

Draft
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:lta-expand-before-inf-outlives
Draft

fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:lta-expand-before-inf-outlives

Conversation

@fmease

@fmease fmease commented May 14, 2025 •

Copy link
Copy Markdown
Member

Supersedes #122340 (see lengthy discussions in comments).
Follow-up to #119350.

Draft status: Need to add more tests, will do later — am at conf. Also: Needs better PR descr.

r? oli-obk

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-types Relevant to the types team, which will review and decide on the PR/issue. F-checked_type_aliases `#![feature(checked_type_aliases)]` (formerly: `lazy_type_alias`) labels May 14, 2025
@fmease fmease moved this to In Progress in Checked Type Aliases (CTA) May 14, 2025
@fmease fmease changed the title Expand free alias type when computing implied outlives-bounds Expand free alias types when computing implied outlives-bounds May 14, 2025
@fmease
fmease force-pushed the lta-expand-before-inf-outlives branch from 97b0792 to 76795eb Compare May 14, 2025 14:23
@rust-log-analyzer

This comment has been minimized.

@fmease
fmease force-pushed the lta-expand-before-inf-outlives branch from 76795eb to 91783b9 Compare May 14, 2025 15:46
@rust-log-analyzer

This comment was marked as outdated.

@BoxyUwU
BoxyUwU self-requested a review May 27, 2025 13:50
@BoxyUwU BoxyUwU assigned BoxyUwU and unassigned oli-obk May 27, 2025
@rust-bors

This comment was marked as resolved.

@fmease
fmease force-pushed the lta-expand-before-inf-outlives branch from 91783b9 to 235a463 Compare June 10, 2026 08:54
@fmease fmease added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Jun 10, 2026
@fmease

fmease commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 10, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 10, 2026
Expand free alias types when computing implied outlives-bounds
@rust-bors

rust-bors Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 3095448 (30954483616bccadbc38ed56731f15772acd0126, parent: ab26b175979ee7b2cb3302dce204b99df96f7efb)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3095448): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.5%, -0.2%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.3%, secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [0.3%, 2.5%] 3
Improvements ✅
(primary)
-3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)
-5.4% [-5.4%, -5.4%] 1
All ❌✅ (primary) -3.3% [-3.3%, -3.3%] 1

Cycles

Results (secondary 19.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
19.6% [19.6%, 19.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 516.59s -> 517.566s (0.19%)
Artifact size: 401.43 MiB -> 401.44 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-checked_type_aliases `#![feature(checked_type_aliases)]` (formerly: `lazy_type_alias`) rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-types Relevant to the types team, which will review and decide on the PR/issue.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

6 participants