Skip to content

rustdoc: even spacing in crate brand heading - #146175

Open
notriddle wants to merge 1 commit into
rust-lang:mainfrom
notriddle:crate-brand
Open

notriddle wants to merge 1 commit into
rust-lang:mainfrom
notriddle:crate-brand

Conversation

@notriddle

Copy link
Copy Markdown
Contributor

Since the search bar and the crate name don't need aligned any more, the layout of the version can be a bit more natural-looking.

This PR is a bit of a follow-up for #115948 and #117906

Before:

image image image

After:

image image image

@rustbot

rustbot commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 3, 2025
@rustbot

rustbot commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

Since the search bar and the crate name don't need aligned any more,
the layout of the version can be a bit more natural-looking.
@GuillaumeGomez

Copy link
Copy Markdown
Member

Is there any reason for doing so? That's more complexity for something barely noticeable after all. ^^'

@lolbinarycat

Copy link
Copy Markdown
Contributor

I honestly can't even tell what's different

@notriddle

notriddle commented Sep 4, 2025 •

Copy link
Copy Markdown
Contributor Author

Okay, here it is with some linework added:

Before:
old

After:
new

@rust-bors

rust-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #157398) made this pull request unmergeable. Please resolve the merge conflicts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants