Suggest fully qualified path on method name collision by estebank · Pull Request #153662 · rust-lang/rust

estebank · 2026-03-10T15:51:55Z

Provide suggestion for using a fully qualified path when method names collide between traits and inherent impl.

error[E0061]: this method takes 0 arguments but 1 argument was supplied
  --> $DIR/shadowed-intrinsic-method.rs:20:7
   |
LL |     a.borrow(());
   |       ^^^^^^ -- unexpected argument of type `()`
   |
note: the `borrow` call is resolved to the method in `std::borrow::Borrow`, shadowing the method of the same name on the inherent impl for `A`
  --> $DIR/shadowed-intrinsic-method.rs:20:7
   |
LL | use std::borrow::Borrow;
   |     ------------------- `std::borrow::Borrow` imported here
...
LL |     a.borrow(());
   |       ^^^^^^ refers to `std::borrow::Borrow::borrow`
note: method defined here
  --> $SRC_DIR/core/src/borrow.rs:LL:COL
help: you might have meant to call the other method; you can use the fully-qualified path to call it explicitly
   |
LL -     a.borrow(());
LL +     A::borrow(&mut a, ());
   |
help: remove the extra argument
   |
LL -     a.borrow(());
LL +     a.borrow();
   |

Fix #54103.

rustbot · 2026-03-10T15:52:01Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 17 candidates

estebank · 2026-03-10T17:06:00Z

-                        ),
-                    ),
+                let fn_sig = self.tcx.fn_sig(m.def_id);
+                if fn_sig.skip_binder().inputs().skip_binder().len() != args.len() + 1 {


We should be running this logic 3 times: one for "all of the arguments apply", "the number of arguments match" and "only the name matches", in order. If any of the cases happens, break (as we get less and less confident the further away we get from things matching).

Detect inherent method behind deref being shadowed by trait method ``` error[E0277]: the trait bound `Rc<RefCell<S>>: Borrow<S>` is not satisfied --> $DIR/shadowed-intrinsic-method-deref.rs:16:22 | LL | let sb : &S = &s.borrow(); | ^^^^^^ the trait `Borrow<S>` is not implemented for `Rc<RefCell<S>>` | help: the trait `Borrow<S>` is not implemented for `Rc<RefCell<S>>` but trait `Borrow<RefCell<S>>` is implemented for it --> $SRC_DIR/alloc/src/rc.rs:LL:COL = help: for that trait implementation, expected `RefCell<S>`, found `S` = note: there's an inherent method on `RefCell<S>` of the same name, which can be auto-dereferenced from `&RefCell<T>` help: to access the inherent method on `RefCell<S>`, use the fully-qualified path | LL - let sb : &S = &s.borrow(); LL + let sb : &S = &RefCell::borrow(&s); | ``` In the example above, method `borrow` is available both on `<RefCell<S> as Borrow<S>>` *and* on `RefCell<S>`. Adding the import `use std::borrow::Borrow;` causes `s.borrow()` to find the former instead of the latter. We now point out that the other exists, and provide a suggestion on how to call it. Fix rust-lang#41906. CC rust-lang#153662.

Detect inherent method behind deref being shadowed by trait method ``` error[E0277]: the trait bound `Rc<RefCell<S>>: Borrow<S>` is not satisfied --> $DIR/shadowed-intrinsic-method-deref.rs:16:22 | LL | let sb : &S = &s.borrow(); | ^^^^^^ the trait `Borrow<S>` is not implemented for `Rc<RefCell<S>>` | help: the trait `Borrow<S>` is not implemented for `Rc<RefCell<S>>` but trait `Borrow<RefCell<S>>` is implemented for it --> $SRC_DIR/alloc/src/rc.rs:LL:COL = help: for that trait implementation, expected `RefCell<S>`, found `S` = note: there's an inherent method on `RefCell<S>` of the same name, which can be auto-dereferenced from `&RefCell<T>` help: to access the inherent method on `RefCell<S>`, use the fully-qualified path | LL - let sb : &S = &s.borrow(); LL + let sb : &S = &RefCell::borrow(&s); | ``` In the example above, method `borrow` is available both on `<RefCell<S> as Borrow<S>>` *and* on `RefCell<S>`. Adding the import `use std::borrow::Borrow;` causes `s.borrow()` to find the former instead of the latter. We now point out that the other exists, and provide a suggestion on how to call it. Fix rust-lang/rust#41906. CC rust-lang/rust#153662.

davidtwco

LGTM

View changes since this review

davidtwco · 2026-03-25T14:07:28Z

@bors r+ rollup

rust-bors · 2026-03-25T14:07:31Z

📌 Commit 67036af has been approved by davidtwco

It is now in the queue for this repository.

…ath, r=davidtwco Suggest fully qualified path on method name collision Provide suggestion for using a fully qualified path when method names collide between traits and inherent impl. ``` error[E0061]: this method takes 0 arguments but 1 argument was supplied --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | a.borrow(()); | ^^^^^^ -- unexpected argument of type `()` | note: the `borrow` call is resolved to the method in `std::borrow::Borrow`, shadowing the method of the same name on the inherent impl for `A` --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | use std::borrow::Borrow; | ------------------- `std::borrow::Borrow` imported here ... LL | a.borrow(()); | ^^^^^^ refers to `std::borrow::Borrow::borrow` note: method defined here --> $SRC_DIR/core/src/borrow.rs:LL:COL help: you might have meant to call the other method; you can use the fully-qualified path to call it explicitly | LL - a.borrow(()); LL + A::borrow(&mut a, ()); | help: remove the extra argument | LL - a.borrow(()); LL + a.borrow(); | ``` Fix rust-lang#54103.

JonathanBrouwer · 2026-03-25T18:52:15Z

@bors r-
#154378 (comment)

rust-bors · 2026-03-25T18:52:22Z

This pull request was unapproved.

This PR was contained in a rollup (#154378), which was unapproved.

davidtwco · 2026-03-26T15:03:33Z

@bors r+

rust-bors · 2026-03-26T15:03:37Z

📌 Commit 0bd2852 has been approved by davidtwco

It is now in the queue for this repository.

…ath, r=davidtwco Suggest fully qualified path on method name collision Provide suggestion for using a fully qualified path when method names collide between traits and inherent impl. ``` error[E0061]: this method takes 0 arguments but 1 argument was supplied --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | a.borrow(()); | ^^^^^^ -- unexpected argument of type `()` | note: the `borrow` call is resolved to the method in `std::borrow::Borrow`, shadowing the method of the same name on the inherent impl for `A` --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | use std::borrow::Borrow; | ------------------- `std::borrow::Borrow` imported here ... LL | a.borrow(()); | ^^^^^^ refers to `std::borrow::Borrow::borrow` note: method defined here --> $SRC_DIR/core/src/borrow.rs:LL:COL help: you might have meant to call the other method; you can use the fully-qualified path to call it explicitly | LL - a.borrow(()); LL + A::borrow(&mut a, ()); | help: remove the extra argument | LL - a.borrow(()); LL + a.borrow(); | ``` Fix rust-lang#54103.

Rollup of 7 pull requests Successful merges: - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #154031 (Remove divergence check from check_expr_array) - #154418 (move many tests out of `ui/unsafe`) - #153662 (Suggest fully qualified path on method name collision) - #153675 (simd_add/sub/mul/neg: document overflow behavior) - #154110 (Change "error finalizing incremental compilation" text and emit it as a note, not a warning) - #154430 (Create GPU target notification group)

Suggest fully qualified path on method name collision try-job: test-various

rust-bors · 2026-04-15T02:06:00Z

💔 Test for 2ae35b0 failed: CI. Failed job:

try - test-various (web logs, enhanced plaintext logs)

davidtwco · 2026-06-12T14:31:47Z

@bors r+

rust-bors · 2026-06-12T14:31:50Z

📌 Commit efa9ba0 has been approved by davidtwco

It is now in the queue for this repository.

…ath, r=davidtwco Suggest fully qualified path on method name collision Provide suggestion for using a fully qualified path when method names collide between traits and inherent impl. ``` error[E0061]: this method takes 0 arguments but 1 argument was supplied --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | a.borrow(()); | ^^^^^^ -- unexpected argument of type `()` | note: the `borrow` call is resolved to the method in `std::borrow::Borrow`, shadowing the method of the same name on the inherent impl for `A` --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | use std::borrow::Borrow; | ------------------- `std::borrow::Borrow` imported here ... LL | a.borrow(()); | ^^^^^^ refers to `std::borrow::Borrow::borrow` note: method defined here --> $SRC_DIR/core/src/borrow.rs:LL:COL help: you might have meant to call the other method; you can use the fully-qualified path to call it explicitly | LL - a.borrow(()); LL + A::borrow(&mut a, ()); | help: remove the extra argument | LL - a.borrow(()); LL + a.borrow(); | ``` Fix rust-lang#54103.

JonathanBrouwer · 2026-06-12T18:38:48Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157827 (comment)

rust-bors · 2026-06-12T18:38:56Z

This pull request was unapproved.

This PR was contained in a rollup (#157827), which was unapproved.

View changes since this unapproval

estebank · 2026-06-12T23:02:33Z

Yeah. I think I need to figure out a way to replicate the environment locally. It seems like under some platforms, the test suite includes different crates in the environment than in other platforms, including when testing locally. I'll try to figure this out, but could use with a pointer if anyone is more familiar with this kind of discrepancy.

``` error[E0061]: this method takes 0 arguments but 1 argument was supplied --> $DIR/shadowed-intrinsic-method.rs:18:7 | LL | a.borrow(()); | ^^^^^^ -- unexpected argument of type `()` | note: the `borrow` call is resolved to the method in `std::borrow::Borrow`, shadowing the method of the same name on the inherent impl for `A` --> $DIR/shadowed-intrinsic-method.rs:18:7 | LL | use std::borrow::Borrow; | ------------------- `std::borrow::Borrow` imported here ... LL | a.borrow(()); | ^^^^^^ refers to `std::borrow::Borrow::borrow` note: method defined here --> $SRC_DIR/core/src/borrow.rs:LL:COL help: you might have meant to call the other method; you can use the fully-qualified path to call it explicitly | LL - a.borrow(()); LL + A::borrow(&mut a, ()); | help: remove the extra argument | LL - a.borrow(()); LL + a.borrow(); | ``` Account for inherent methods Tweak wording on "other methods available" note Handle correct gramar in the face of a single other option, or many.

rustbot · 2026-09-19T21:12:43Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

estebank · 2026-09-19T22:43:16Z

@bors r=davidtwco

rust-bors · 2026-09-19T22:43:19Z

📌 Commit 09fb849 has been approved by davidtwco

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: GitHub outage

Rollup of 17 pull requests Successful merges: - #158515 (Make let-else respect macro_rules expr metavariable grouping) - #160028 (Better account for `Self` that might be a typo of `self`) - #160097 (fix const_item_mutation lint to use needs_drop instead of has_dtor) - #161435 (Provide a `supertrait_def_ids()` function in rustc_type_ir's interner) - #161894 (Do not suppress the fn item uniqueness note for late bound lifetimes) - #162990 (post GH comment on types nominations) - #153662 (Suggest fully qualified path on method name collision) - #154665 (add safety section for mem::zeroed) - #159787 (Prefer ModId in more places) - #162700 ( Remove incorrect parse error recovery code that mistakes `as` casts for the long removed type ascription) - #162705 (Trigger "C array" parse error recovery in far fewer cases) - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt) - #162988 (recover `true` and `false` in type position as `bool`) - #162995 (Constify `impl FromStr for NonZero<T>`) - #163006 (Use `end_point` for trailing brace in `let...else` diagnostics) - #163007 (add Dir::try_clone) - #163039 (Use verbose suggestion for parenthetical `Fn` notation and fully-qualified path on ambiguous assoc item)

Rollup merge of #153662 - estebank:suggest-fully-qualified-path, r=davidtwco Suggest fully qualified path on method name collision Provide suggestion for using a fully qualified path when method names collide between traits and inherent impl. ``` error[E0061]: this method takes 0 arguments but 1 argument was supplied --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | a.borrow(()); | ^^^^^^ -- unexpected argument of type `()` | note: the `borrow` call is resolved to the method in `std::borrow::Borrow`, shadowing the method of the same name on the inherent impl for `A` --> $DIR/shadowed-intrinsic-method.rs:20:7 | LL | use std::borrow::Borrow; | ------------------- `std::borrow::Borrow` imported here ... LL | a.borrow(()); | ^^^^^^ refers to `std::borrow::Borrow::borrow` note: method defined here --> $SRC_DIR/core/src/borrow.rs:LL:COL help: you might have meant to call the other method; you can use the fully-qualified path to call it explicitly | LL - a.borrow(()); LL + A::borrow(&mut a, ()); | help: remove the extra argument | LL - a.borrow(()); LL + a.borrow(); | ``` Fix #54103.

rustbot assigned davidtwco Mar 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 10, 2026

estebank commented Mar 10, 2026

View reviewed changes

estebank mentioned this pull request Mar 10, 2026

Detect inherent method behind deref being shadowed by trait method #153674

Merged

davidtwco approved these changes Mar 25, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026

JonathanBrouwer mentioned this pull request Mar 25, 2026

Rollup of 21 pull requests #154378

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 25, 2026

estebank force-pushed the suggest-fully-qualified-path branch from 67036af to 0bd2852 Compare March 25, 2026 19:22

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2026

JonathanBrouwer mentioned this pull request Mar 26, 2026

Rollup of 9 pull requests #154438

Closed

matthiaskrgr mentioned this pull request Mar 26, 2026

Rollup of 7 pull requests #154440

Closed

rust-bors Bot pushed a commit that referenced this pull request Apr 15, 2026

Auto merge of #153662 - estebank:suggest-fully-qualified-path, r=<try>

2ae35b0

Suggest fully qualified path on method name collision try-job: test-various

This comment has been minimized.

Sign in to view

estebank force-pushed the suggest-fully-qualified-path branch from c53fc09 to efa9ba0 Compare May 16, 2026 00:53

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2026

JonathanBrouwer mentioned this pull request Jun 12, 2026

Rollup of 23 pull requests #157827

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2026

This comment has been minimized.

Sign in to view

estebank force-pushed the suggest-fully-qualified-path branch from efa9ba0 to 09fb849 Compare September 19, 2026 21:12

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2026

mu001999 mentioned this pull request Sep 20, 2026

Rollup of 17 pull requests #163043

Merged

rust-bors Bot merged commit fdd54bd into rust-lang:main Sep 20, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 20, 2026

Uh oh!

Conversation

estebank commented Mar 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 10, 2026

Uh oh!

estebank Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

davidtwco left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidtwco commented Mar 25, 2026

Uh oh!

rust-bors Bot commented Mar 25, 2026

Uh oh!

JonathanBrouwer commented Mar 25, 2026

Uh oh!

rust-bors Bot commented Mar 25, 2026

Uh oh!

This comment has been minimized.

davidtwco commented Mar 26, 2026

Uh oh!

rust-bors Bot commented Mar 26, 2026

Uh oh!

rust-bors Bot commented Apr 15, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

davidtwco commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

JonathanBrouwer commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

estebank commented Jun 12, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 19, 2026

Uh oh!

estebank commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estebank commented Mar 10, 2026 •

edited by rustbot

Loading

davidtwco left a comment •

edited by rustbot

Loading