Skip to content

bootstrap: -Zjson-target-spec for synthetic targets - #154428

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
davidtwco:json-target-spec-synthetic-targets
Mar 28, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
davidtwco:json-target-spec-synthetic-targets

Conversation

@davidtwco

@davidtwco davidtwco commented Mar 26, 2026 •

Copy link
Copy Markdown
Member

Fixes #154340

Synthetic targets for mir-opt tests build a standard library using a .json target, which now requires -Zjson-target-spec

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 26, 2026
@ehuss

ehuss commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Thanks! I did not know about that field when posting #152677. I did a bunch of testing with the now-beta cargo, but missed this one.

@jieyouxu

jieyouxu commented Mar 26, 2026 •

Copy link
Copy Markdown
Member

Just to check my understanding (I might've gotten my release cadence slightly off), we only need this against main, we don't need a beta-backport right?

@jieyouxu jieyouxu left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8fc0581 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2026
rust-bors Bot pushed a commit that referenced this pull request Mar 27, 2026
Rollup of 10 pull requests

Successful merges:

 - #154070 (Unstable book options parser)
 - #154371 (Use LocalDefId for more tcx method calls)
 - #154405 (Improve doc comment unicode guidance)
 - #154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…)
 - #153528 (Fix LegacyKeyValueFormat report from docker build: mips)
 - #154246 (Add test for issue #101532: dead code warnings in const _)
 - #154421 (Rustdoc rejects html emits with json output)
 - #154428 (bootstrap: `-Zjson-target-spec` for synthetic targets)
 - #154437 (bootstrap.example.toml: Hint how to allow `build.warnings`)
 - #154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations)

Failed merges:

 - #154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
rust-bors Bot pushed a commit that referenced this pull request Mar 27, 2026
Rollup of 10 pull requests

Successful merges:

 - #154070 (Unstable book options parser)
 - #154371 (Use LocalDefId for more tcx method calls)
 - #154405 (Improve doc comment unicode guidance)
 - #154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…)
 - #153528 (Fix LegacyKeyValueFormat report from docker build: mips)
 - #154246 (Add test for issue #101532: dead code warnings in const _)
 - #154421 (Rustdoc rejects html emits with json output)
 - #154428 (bootstrap: `-Zjson-target-spec` for synthetic targets)
 - #154437 (bootstrap.example.toml: Hint how to allow `build.warnings`)
 - #154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations)

Failed merges:

 - #154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
@rust-bors
rust-bors Bot merged commit e8994ea into rust-lang:main Mar 28, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 28, 2026
rust-timer added a commit that referenced this pull request Mar 28, 2026
Rollup merge of #154428 - davidtwco:json-target-spec-synthetic-targets, r=jieyouxu

bootstrap: `-Zjson-target-spec` for synthetic targets

Fixes #154340

Synthetic targets for mir-opt tests build a standard library using a `.json` target, which now requires `-Zjson-target-spec`

r? @jieyouxu
@davidtwco
davidtwco deleted the json-target-spec-synthetic-targets branch March 30, 2026 08:50
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#154070 (Unstable book options parser)
 - rust-lang/rust#154371 (Use LocalDefId for more tcx method calls)
 - rust-lang/rust#154405 (Improve doc comment unicode guidance)
 - rust-lang/rust#154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…)
 - rust-lang/rust#153528 (Fix LegacyKeyValueFormat report from docker build: mips)
 - rust-lang/rust#154246 (Add test for issue rust-lang/rust#101532: dead code warnings in const _)
 - rust-lang/rust#154421 (Rustdoc rejects html emits with json output)
 - rust-lang/rust#154428 (bootstrap: `-Zjson-target-spec` for synthetic targets)
 - rust-lang/rust#154437 (bootstrap.example.toml: Hint how to allow `build.warnings`)
 - rust-lang/rust#154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations)

Failed merges:

 - rust-lang/rust#154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

./x test mir-opt --bless fails due to missing -Zjson-target-spec

4 participants