[PERF] cache for unnormalized projection goal - #159001
adwinwhite wants to merge 1 commit into
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[PERF] do not normalize projection goal in `add_goal`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (8d5f36a): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.9%, secondary 6.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.352s -> 488.208s (-0.23%) |
add_goal|
☔ The latest upstream changes (presumably #163583) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This commit doesn't make much sense. I'll try to cache normalized result + stalled goals instead, in a separate cache for unnormalized projection goal.
r? @ghost