Skip to content

Use attribute parser for #[non_exhaustive] attribute check - #161482

Open
obeis wants to merge 1 commit into
rust-lang:mainfrom
obeis:check-non-exhaustive
Open

Use attribute parser for #[non_exhaustive] attribute check#161482
obeis wants to merge 1 commit into
rust-lang:mainfrom
obeis:check-non-exhaustive

Conversation

@obeis

@obeis obeis commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to diagnostic attributes.

cc @mejrs

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 21, 2026
@rust-log-analyzer

This comment has been minimized.

@mejrs

mejrs commented Aug 21, 2026

Copy link
Copy Markdown
Member

I'm not sure about this change. We'd like to have more of these checks in attribute parsing but we also don't want to make Target more complicated. I think this one is too much "makes Target complicated".

@JonathanBrouwer

Copy link
Copy Markdown
Member

Indeed, this information also feels too specific to add to the Target type for me.

Comment thread compiler/rustc_hir/src/target_impls.rs Outdated
@JonathanBrouwer

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2026
@rustbot

rustbot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-bors

This comment has been minimized.

@obeis
obeis force-pushed the check-non-exhaustive branch from 7074c3b to 895661b Compare August 23, 2026 00:23
@rustbot

rustbot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@obeis
obeis requested a review from JonathanBrouwer August 23, 2026 00:24
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2026
@obeis
obeis force-pushed the check-non-exhaustive branch from 895661b to 2c7e6b6 Compare August 23, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants