make Destruct trait coinductive - #162399
Draft
RedDaedalus wants to merge 1 commit into
Draft
RedDaedalus wants to merge 1 commit into
RedDaedalus wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
RedDaedalus
force-pushed
the
destruct-coinductivity
branch
from
September 7, 2026 05:03
566bf71 to
6e907e3
Compare
Contributor
|
☔ The latest upstream changes (presumably #163583) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
Destruct#[rustc_coinductive], and switches the goal source for the builtinDestructimpl conditions toImplWhereBound, which is required for coinduction to apply. This allows recursive types to beDestruct. Fixes #162217As a disclaimer, this is my first time contributing to the trait system so my knowledge of the internals is lacking and I may very well have taken the wrong approach/missed implications of the changes I made here. This code was hand-written without the assistance of an LLM.