yeet AliasConstKind::opt_def_id by khyperia · Pull Request #162797 · rust-lang/rust

khyperia · 2026-09-15T07:02:47Z

A while back, I made three PRs removing def_id from AliasConst/AliasTerm/AliasTy:

I did AliasConst first, and due to my inexperience with this refactor, I had this opt_def_id kludge. I didn't do the same thing in the AliasTy or AliasTerm PRs. It ought to be removed and replaced with explicit matches.

related tracking-ish issues:

move Alias[Ty|Const|Term]Kind into Alias[Ty|Const|Term], generalize to not require just a DefId #152245
Internal Tracking Issue for the AliasTerm refactor #156181
[Goal]: unify representations of ConstKind::Unevaluated and TyKind::Alias and allow non defid/subst pairs project-const-generics#98
goodness we have a lot of issues on this general area of work

r? @BoxyUwU

rustbot · 2026-09-15T07:02:50Z

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred in abstract_const.rs

cc @BoxyUwU

Some changes occurred in match checking

cc @Nadrieril

HIR ty lowering was modified

cc @fmease

rustbot · 2026-09-15T07:02:53Z

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

bit-aloo

LGTM 🚀

View changes since this review

BoxyUwU

r=me,bit-aloo

View changes since this review

BoxyUwU · 2026-09-16T09:41:30Z

+                                // we are not instantiating the result, so it's OK here.
+                                def_id
+                            }
+                            ty::AliasConstKind::InherentImpl { def_id } => def_id,


is inherent impl reachable here? the type from const_param_default ought to be unnormalized and so in InherentSelf form

it is unreachable. it is from const_param_default->lower_const_arg->lower_type_relative_const_path->blah blah unnormalized. the rest are reachable though (at first I was like "can't it only be anons?" but no it can be directly represented paths too)

BoxyUwU · 2026-09-16T09:42:19Z

            }
            Res::Def(DefKind::Const, did) => {
-                if let Err(guar) = self.check_const_item_in_type_system(did, span) {
+                let alias_const_kind = ty::AliasConstKind::new_from_def_id(


given that this is never an inherent const it would be nice to use a different constructor here that doesnt take AliasConstInherentArgsKind

#162760 I suppose

exactly:

This PR conflicts with #162760 - please merge that one first! the code in this PR is a bit kludgey until that PR is merged.

(this is one of the kludgey spots)

rustbot · 2026-09-18T07:34:40Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

khyperia · 2026-09-18T12:58:37Z

@bors r=BoxyUwU,bit-aloo rollup

rust-bors · 2026-09-18T12:58:40Z

📌 Commit 653076c has been approved by BoxyUwU,bit-aloo

It is now in the queue for this repository.

@BoxyUwU

…U,bit-aloo yeet AliasConstKind::opt_def_id A while back, I made three PRs removing def_id from AliasConst/AliasTerm/AliasTy: - rust-lang#157374 - rust-lang#157653 - rust-lang#158013 I did AliasConst first, and due to my inexperience with this refactor, I had this `opt_def_id` kludge. I didn't do the same thing in the AliasTy or AliasTerm PRs. It ought to be removed and replaced with explicit matches. related tracking-ish issues: - rust-lang#152245 - rust-lang#156181 - rust-lang/project-const-generics#98 - goodness we have a lot of issues on this general area of work r? @BoxyUwU

…uwer Rollup of 8 pull requests Successful merges: - #160859 (`core::num::f16b` Rust's 16bit Brain Float) - #162177 (Properly implement the gpu-kernel ABI for amdgpu) - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area) - #162733 (Add useful APIs to `Unique(Arc|Rc)`) - #162950 (More AST lowering cleanups) - #162964 (Update `browser-ui-test` version to `0.25.2`) - #162797 (yeet AliasConstKind::opt_def_id) - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)

@BoxyUwU

…U,bit-aloo yeet AliasConstKind::opt_def_id A while back, I made three PRs removing def_id from AliasConst/AliasTerm/AliasTy: - rust-lang#157374 - rust-lang#157653 - rust-lang#158013 I did AliasConst first, and due to my inexperience with this refactor, I had this `opt_def_id` kludge. I didn't do the same thing in the AliasTy or AliasTerm PRs. It ought to be removed and replaced with explicit matches. related tracking-ish issues: - rust-lang#152245 - rust-lang#156181 - rust-lang/project-const-generics#98 - goodness we have a lot of issues on this general area of work r? @BoxyUwU

Rollup of 18 pull requests Successful merges: - #162499 (`rustc_codegen_gcc` subtree update) - #161424 (implement `VaArgSafe` for `f128`) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162506 (Avoid suggesting imports of traits declared inside fn bodies) - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area) - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names) - #162733 (Add useful APIs to `Unique(Arc|Rc)`) - #162913 (Refactor LivenessResults into LivenessComputation, without typeck) - #162950 (More AST lowering cleanups) - #162964 (Update `browser-ui-test` version to `0.25.2`) - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`) - #161743 (Add performance notes for the floating-point round method) - #162797 (yeet AliasConstKind::opt_def_id) - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports) - #162873 (Adjust `bug!`/`span_bug!` emission) - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt) - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests) - #162981 (rustc-dev-guide subtree update) Failed merges: - #162177 (Properly implement the gpu-kernel ABI for amdgpu)

@BoxyUwU

…U,bit-aloo yeet AliasConstKind::opt_def_id A while back, I made three PRs removing def_id from AliasConst/AliasTerm/AliasTy: - rust-lang#157374 - rust-lang#157653 - rust-lang#158013 I did AliasConst first, and due to my inexperience with this refactor, I had this `opt_def_id` kludge. I didn't do the same thing in the AliasTy or AliasTerm PRs. It ought to be removed and replaced with explicit matches. related tracking-ish issues: - rust-lang#152245 - rust-lang#156181 - rust-lang/project-const-generics#98 - goodness we have a lot of issues on this general area of work r? @BoxyUwU

…uwer Rollup of 22 pull requests Successful merges: - #163001 (Temporarily disable `test-x86_64-fuchsia`) - #162880 (Mini optimization in `rustc_hir_typeck::upvar::restrict_precision_for_drop_types`) - #161424 (implement `VaArgSafe` for `f128`) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162506 (Avoid suggesting imports of traits declared inside fn bodies) - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area) - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names) - #162733 (Add useful APIs to `Unique(Arc|Rc)`) - #162913 (Refactor LivenessResults into LivenessComputation, without typeck) - #162924 (Remove applying inline attributes at the callsite) - #162940 (Use spawned `SBDebugger` instance) - #162950 (More AST lowering cleanups) - #162964 (Update `browser-ui-test` version to `0.25.2`) - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`) - #161743 (Add performance notes for the floating-point round method) - #162797 (yeet AliasConstKind::opt_def_id) - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports) - #162873 (Adjust `bug!`/`span_bug!` emission) - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests) - #162971 (libtest harness: avoid 'extern crate test' with custom runner) - #162981 (rustc-dev-guide subtree update) - #162985 (Error on invalid placements for unstable attributes)

@BoxyUwU

Rollup merge of #162797 - khyperia:yeet-opt_def_id, r=BoxyUwU,bit-aloo yeet AliasConstKind::opt_def_id A while back, I made three PRs removing def_id from AliasConst/AliasTerm/AliasTy: - #157374 - #157653 - #158013 I did AliasConst first, and due to my inexperience with this refactor, I had this `opt_def_id` kludge. I didn't do the same thing in the AliasTy or AliasTerm PRs. It ought to be removed and replaced with explicit matches. related tracking-ish issues: - #152245 - #156181 - rust-lang/project-const-generics#98 - goodness we have a lot of issues on this general area of work r? @BoxyUwU

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2026

rustbot assigned BoxyUwU Sep 15, 2026

bit-aloo approved these changes Sep 15, 2026

View reviewed changes

BoxyUwU approved these changes Sep 16, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

yeet AliasConstKind::opt_def_id

653076c

khyperia force-pushed the yeet-opt_def_id branch from 08ce7fd to 653076c Compare September 18, 2026 07:34

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 8 pull requests #162975

Closed

Zalathar mentioned this pull request Sep 19, 2026

Rollup of 18 pull requests #162996

Closed

This was referenced Sep 19, 2026

Rollup of 20 pull requests #163000

Closed

Rollup of 22 pull requests #163002

Merged

rust-bors Bot merged commit eacd646 into rust-lang:main Sep 19, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 19, 2026

Navigation Menu

Uh oh!

yeet AliasConstKind::opt_def_id - #162797

yeet AliasConstKind::opt_def_id#162797
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
khyperia:yeet-opt_def_id

khyperia commented Sep 15, 2026 •

edited

Loading

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

bit-aloo left a comment •

edited by rustbot

Loading

Uh oh!

BoxyUwU left a comment •

edited by rustbot

Loading

Uh oh!

BoxyUwU Sep 16, 2026

Uh oh!

khyperia Sep 16, 2026 •

edited

Loading

Uh oh!

BoxyUwU Sep 16, 2026

Uh oh!

BoxyUwU Sep 16, 2026

Uh oh!

khyperia Sep 16, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 18, 2026

Uh oh!

khyperia commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

khyperia commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

bit-aloo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

khyperia Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

BoxyUwU Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

khyperia Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Sep 18, 2026

Uh oh!

khyperia commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

khyperia commented Sep 15, 2026 •

edited

Loading

bit-aloo left a comment •

edited by rustbot

Loading

BoxyUwU left a comment •

edited by rustbot

Loading

khyperia Sep 16, 2026 •

edited

Loading