Conversation
Collaborator
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
S-waiting-on-review
Member
|
I think you'll need to rebase before this works, but let's try. @bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
Member
|
I tested dist locally and it works. You just shouldn't need the target check anymore after the rebase, since we simplified the build in a pr merged yesterday. |
rust-cloud-vms
Bot
force-pushed
the
offload-remove-ldlibrarypath
branch
from
September 17, 2026 13:23
c5e7260 to
0db4e55
Compare
Member
|
@bors try jobs=dist-x86_64-linux |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
offload: add libLLVM rpath for libomptarget try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
Contributor
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 17, 2026
…h, r=ZuseZ4 offload: add libLLVM rpath for libomptarget fix: rust-lang#162309 (comment) We can remove LD_LIBRARY_PATH=$(rustc +nightly --print sysroot)/lib when we run the offload code after this PR lands. libomptarget.so is in lib/rustlib/${target}/lib, and libLLVM is in lib/, three hierarchy above libomptarget. So we can specify $ORIGIN/../../../ Lld::run uses the same logic. <img width="520" height="285" alt="スクリーンショット 2026-09-17 3 16 48" src="https://github.com/user-attachments/assets/d8f4938d-7e37-4e56-af61-9f2ed7f2e5fc" /> <img width="589" height="454" alt="スクリーンショット 2026-09-17 3 17 02" src="https://github.com/user-attachments/assets/b5e8bf27-38b1-460c-a113-20176a669a05" /> I have not verified if it works yet. I'll share the result I can test on my local machine later, but testing using tarballs would be better? r? @ZuseZ4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #162309 (comment)
We can remove LD_LIBRARY_PATH=$(rustc +nightly --print sysroot)/lib when we run the offload code after this PR lands.
libomptarget.so is in lib/rustlib/${target}/lib, and libLLVM is in lib/, three hierarchy above libomptarget. So we can specify $ORIGIN/../../../
Lld::run uses the same logic.
I have not verified if it works yet. I'll share the result I can test on my local machine later, but testing using tarballs would be better?
r? @ZuseZ4