Rollup of 2 pull requests - #163392
Merged
Merged
Rollup of 2 pull requests#163392
Conversation
…fonthey Guarantee 8 bytes of alignment of RawWakerVTable This is similar to an earlier PR I made for `Thread::into_raw`: rust-lang#143859. When using `AtomicPtr` for synchronization it's incredibly useful when you've got a couple bits you can stuff metadata in. By guaranteeing that `RawWakerVTable` is aligned to 8 bytes everyone can use the bottom 3 bits to signal other things, such as a critical section, etc. In particular, this can be used to portably implement an `AtomicWaker` which is always two pointers in size, no more. On almost all platforms the align is already 8 bytes, and on other platforms it might cause an infinitesimal increase in size. This guarantee is thus very useful and costs us essentially nothing. --- r? libs-api Like last time since this adds a guarantee this probably needs a FCP.
Update books ## rust-lang/reference 2 commits in e24eecf97b0c9a6dbac67191098204dc8a190aaa..4245282b97496585e73862b966d639cbb553bd6c 2026-09-15 19:41:20 UTC to 2026-09-15 17:32:28 UTC - Glossary: add entry and examples for `n-zst` (rust-lang/reference#2357) - Document RISC-V d and f extensions (rust-lang/reference#2355) ## rust-lang/rust-by-example 4 commits in 15308f3e951814ef3475d2b58f48276e6b17b9af..af5ef7024e88587aa3be244422f6365e86c50e85 2026-09-15 14:15:08 UTC to 2026-09-15 14:13:27 UTC - Better formatting (rust-lang/rust-by-example#2024) - Add an example of accessing Union elements (unsafe) (rust-lang/rust-by-example#2027) - Improve linked list example (rust-lang/rust-by-example#2022) - Fix typo in TRANSLATING.md (rust-lang/rust-by-example#2028)
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 75a75c3 (parent) -> c231371 (this PR) Test differencesShow 23 test diffs23 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c23137133458bf7a49f4a55d3adb9e2c7c33bd79 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (c231371): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -3.4%, secondary -6.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 1.9%, secondary -1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 487.818s -> 489.459s (0.34%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 75a75c3e0a In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup