Rollup of 2 pull requests - #163423
Closed
JonathanBrouwer wants to merge 6 commits into
Closed
Rollup of 2 pull requests#163423JonathanBrouwer wants to merge 6 commits into
JonathanBrouwer wants to merge 6 commits into
Conversation
```
error: invalid definition of the runtime `open` symbol used by the standard library
--> $DIR/runtime-symbols-unix.rs:14:5
|
LL | pub fn open() {}
| ^^^^^^^^^^^^^
|
= note: expected `unsafe extern "C" fn(*const U8, i32, ...) -> i32` (for the current target)
found `fn()`
= help: either fix the signature or remove any attributes like `#[unsafe(no_mangle)]`, `#[unsafe(export_name = "open")]`, or `#[link_name = "open"]`
= note: `#[deny(invalid_runtime_symbol_definitions)]` on by default
```
…temporarily to keep file history
…=tgross35 Move `Arc` and `Rc` into `rcs` mod See <rust-lang#141348 (comment)>.
…anBrouwer
Tweak "expected/found" indentation for runtime symbols
```
error: invalid definition of the runtime `open` symbol used by the standard library
--> $DIR/runtime-symbols-unix.rs:14:5
|
LL | pub fn open() {}
| ^^^^^^^^^^^^^
|
= note: expected `unsafe extern "C" fn(*const U8, i32, ...) -> i32` (for the current target)
found `fn()`
= help: either fix the signature or remove any attributes like `#[unsafe(no_mangle)]`, `#[unsafe(export_name = "open")]`, or `#[link_name = "open"]`
= note: `#[deny(invalid_runtime_symbol_definitions)]` on by default
```
r? @JonathanBrouwer
rustbot
added
A-translation
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ArcandRcintorcsmod #163331 (MoveArcandRcintorcsmod)Warning
This rollup conflicts with pending auto build #163419 and may need to be recreated if the pending build succeeds.
r? @ghost
Create a similar rollup