Skip to content

Document the rustc_on_unimplemented attribute. - #163508

Open
mejrs wants to merge 1 commit into
rust-lang:mainfrom
mejrs:rustc_on_unimplemented_docs
Open

mejrs wants to merge 1 commit into
rust-lang:mainfrom
mejrs:rustc_on_unimplemented_docs

Conversation

@mejrs

@mejrs mejrs commented Sep 29, 2026

Copy link
Copy Markdown
Member

Moves/improves rustc_on_unimplemented's docs from the dev guide to the compiler, then in the dev guide adds links to it and other relevant diagnostic/lint attributes

Rendered:

image image image image image

@rustbot

rustbot commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If your future PRs only touch the subtree, consider submitting them directly to rust-lang/rustc-dev-guide, which is where the document is primarily maintained (and has faster CI).

cc @BoxyUwU, @tshepang

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2026
@rustbot

rustbot commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 17 candidates

@rust-bors

This comment has been minimized.

@mejrs
mejrs force-pushed the rustc_on_unimplemented_docs branch from 05c9dc2 to c55c824 Compare October 1, 2026 09:43
@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants