Rollup of 8 pull requests - #163630
Merged
Merged
Rollup of 8 pull requests#163630
Conversation
This patch refactors setup of the LegacyPassManager for CodeGen into a single function. This simplifies some things (lifetime for the LegacyPM object), but is primarily aimed at enabling rustc to use the new runCodeGenPipeline abstraction (introduced in LLVM 24) which handles all of these details within LLVM and additionally defaults to the NewPM when a target opts-in/the correct LLVM flag is passed.
This is a well-defined operation that we want to make use of in std/core, such as with `abort_immediate`.
For const-only code there isn't much of a reason to use this over `panic!()`, but having `abort_immediate` const will make it possible to reuse more code meant for runtime at comptime. The semantics are well-defined so this is pretty straightforward.
…actoring-9-9-26, r=cuviper Refactor CodeGen Pipeline Setup into a Single Function This patch refactors setup of the LegacyPassManager for CodeGen into a single function. This simplifies some things (lifetime for the LegacyPM object), but is primarily aimed at enabling rustc to use the new runCodeGenPipeline abstraction (introduced in LLVM 24) which handles all of these details within LLVM and additionally defaults to the NewPM when a target opts-in/the correct LLVM flag is passed.
…acement, r=lolbinarycat rustdoc: Fix where-clause placement of free const items & checked type aliases Embarrassingly, back in rust-lang#113522 while I did correctly implement the rendering for generic assoc consts, I failed to do so for free generic consts. Re. checked type aliases, their where-clause comes last, CC rust-lang#114662; I just never updated rustdoc. <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
…RalfJung,bushrat011899 core: Unstably constify `abort_immediate` For const-only code there isn't much of a reason to use this over `panic!()`, but having `abort_immediate` const will make it possible to reuse more code meant for runtime at comptime. The semantics are well-defined so this is pretty straightforward. Tracking issue: rust-lang#154601
…-Simulacrum declare C and C-unwind as mutually ABI-compatible We left this conservative in rust-lang#115476. That means the following code is currently UB: ```rust extern "C-unwind" fn does_not_unwind_but_could() {} fn main() { let f: extern "C-unwind" fn() = does_not_unwind_but_could; let f: extern "C" fn() = unsafe { std::mem::transmute(f) }; f(); } ``` I think this code should be allowed. [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/ABI.20compatibility.20of.20.22C.22.20vs.20.22C-unwind.22) also led to the conclusion that this should be fine in LLVM -- the `nounwind` attribute does not affect the ABI. This is widely relied upon in the C ecosystem when doing calls between C and C++. Cc @nikic to confirm. I am not sure why rust-lang#115476 left this conservative. There was discussion about explicitly listing the ABIs rather than saying this holds universally for all `*-unwind` that we may add in the future, but there was no discussion I could find about allowing a mismatch both ways. Cc @rust-lang/opsem @rust-lang/lang
…r=wesleywiser Add Tier 3 targets for Hyperlight guests [Hyperlight](https://github.com/hyperlight-dev/hyperlight) is a project which tries to make using hypervisor-assisted sandboxing extremely lightweight. Hyperlight compiles Rust programs to run bare-metal in tiny virtual machines, but needs some target support to do this effectively. This PR is a straightforward port of the json targets that we were [previously](rust-lang#151528 (comment)) using to upstream targets `{aarch64,x86_64}-unknown-hyperlight`. Tier 3 policy: > A tier 3 target must have a designated developer or developers (the “target maintainers”) on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.) I (@syntactically) will maintain this target. Other Hyperlight maintainers are also able to help/may be added to this contact list. > Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target. > - Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it. > - If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo. I think the proposed target names are reasonably in-line with other Rust targets. Because Hyperlight uses a libos-like design, where the supervisor is a rust crate linked with user code, all code built for this target is not strictly running "under" a hyperlight operating system, but I think it's the least confusing option. > Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users. > - The target must not introduce license incompatibilities. > - Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0). > - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements. > - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust’s license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3. > - “onerous” here is an intentionally subjective term. At a minimum, “onerous” legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, “non-commercial”/“research-only”/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users. All of the hyperlight project code that directly works with this target is open source under Apache 2.0. All the dependencies needed to build and use it normally are available under permissive licenses as well. > Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target’s tier status, though they may otherwise participate in discussions. > - This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements. Understood. > Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions. Hyperlight guests have very restricted (and application-specific I/O) available to them, so implementing std is difficult; alloc is, however, implemented. > The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary. The platform support document includes a brief overview of the way the target is meant to be used and links to more detailed documentation on using Hyperlight, which will involve the target once it is merged. > Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages. > - Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications. Understood. > Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target. > - In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target. This patch should not break any other target. It does not change any other target specifications, and the new target is similar to the existing *-unknown-none targets. > Tier 3 targets must be able to produce assembly using at least one of rustc’s supported backends from any host target. (Having support in a fork of the backend is not sufficient, it must be upstream.) These targets have only been tested with the llvm codegen, but it works fine (and is the only supported way to use them). r? compiler
remove unnecessary panic from opsem inhabitedness calculation r? RalfJung follow up to rust-lang#156977
…, r=tgross35 Add tests for `!` and `bool`'s size and alignment to `coretests`. Add tests for `bool` and `!`'s size and alignment to `coretests/tests/mem.rs` cc @tgross35
ignore hanging next-solver tests, remove unnecessary ignore test no clue why rust-lang#114196 used `ignore-test` here 🤣 here are the compile times with the new solver right now, let's ignore the ones with a clear cause I don't care about too much right now ``` 314.551960 [ui] tests/ui/closures/supertrait-hint-cycle.rs 47.479099 [ui] tests/ui/traits/issue-91949-hangs-on-recursion.rs 46.887560 [ui] tests/ui/recursion/issue-83150.rs 26.139618 [ui] tests/ui/type-alias-impl-trait/recursive-drop-elaboration-2.rs 25.931186 [ui] tests/ui/type-alias-impl-trait/recursive-drop-elaboration.rs 25.240523 [ui] tests/ui/try-trait/deep-try-chain-issue-153583.rs 24.969846 [ui] tests/ui/type-alias-impl-trait/error-tainting-issue-122904.rs 21.847410 [ui] tests/ui/consts/const-eval/issue-52475.rs 19.111621 [ui] tests/ui/threads-sendsync/mpsc_stress.rs 18.606682 [ui] tests/ui/process/process-panic-after-fork.rs 14.375541 [ui] tests/ui/type-alias-impl-trait/hkl_forbidden.rs 12.675839 [ui] tests/ui/type-alias-impl-trait/self-referential-4.rs 11.886663 [ui] tests/ui/panic-runtime/lto-abort.rs ``` r? types
rustbot
added
A-LLVM
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 2, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Oct 2, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing dba8825 (parent) -> c165834 (this PR) Test differencesShow 69 test diffsStage 0
Stage 1
Stage 2
Additionally, 10 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c1658342b0ea7eab61db1960082668c77f553522 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (c165834): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -1.6%, secondary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 490.969s -> 491.121s (0.03%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: dba8825fe5 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
abort_immediate#163621 (core: Unstably constifyabort_immediate)!andbool's size and alignment tocoretests. #163570 (Add tests for!andbool's size and alignment tocoretests.)Failed merges:
r? @ghost
Create a similar rollup