Skip to content

outline unreachable! from Clause::kind #163657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panstromek wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

outline unreachable! from Clause::kind #163657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion compiler/rustc_middle/src/ty/predicate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,17 @@ impl<'tcx> Clause<'tcx> {
}

pub fn kind(self) -> ty::Binder<'tcx, ClauseKind<'tcx>> {
// Outline the unreachable! call to make the happy path faster.
// see: https://github.com/rust-lang/rust/pull/163657#issuecomment-5956974964
#[cold]

@lcnr lcnr Oct 2, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put a comment here referencing this perf run, r=me after

View changes since the review

@panstromek panstromek Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks ;) but I don't have r+ rights to approve this

#[inline(never)]
fn unreachable_inner() -> ! {
unreachable!()
}

self.0.internee.map_bound_no_validate_bound_vars(|kind| match kind {
PredicateKind::Clause(clause) => clause,
_ => unreachable!(),
_ => unreachable_inner(),
})
}

Expand Down
Loading