Skip to content

cg_llvm: Use some LLVM-C functions that require LLVM 22 - #163697

Open
Zalathar wants to merge 2 commits into
rust-lang:mainfrom
Zalathar:llvm-22
Open

Zalathar wants to merge 2 commits into
rust-lang:mainfrom
Zalathar:llvm-22

Conversation

@Zalathar

@Zalathar Zalathar commented Oct 3, 2026

Copy link
Copy Markdown
Member

These LLVM-C functions were introduced in LLVM 22, so now that that's our baseline, we can bind to the directly and remove our own C++ wrappers.

This function was added in LLVM 22.
This function was added in LLVM 22.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2026
@rustbot

rustbot commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 18 candidates

@mejrs

mejrs commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

LLVMGetOrInsertFunction has been implemented in #163690

@rust-bors

rust-bors Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #163695) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants