Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
rust-lang
rust
Repository navigation
Code
Issues
5k+
(5k+)
Pull requests
1.4k
(1.4k)
Actions
Projects
Security and quality
6
(6)
Insights
More
items
Unlimit UNIX remove_dir_all() implementation
- #93160
#93160
Closed
hkratz
wants to merge 18 commits into
rust-lang:master
rust-lang/rust:master
from
rusticstuff:unix_remove_dir_all_opt
rusticstuff/rust:unix_remove_dir_all_opt
Copy head branch name to clipboard
Conversation
Commits
18
(18)
Checks
Files changed
Closed
Unlimit UNIX remove_dir_all() implementation
#93160
hkratz
wants to merge 18 commits into
rust-lang:master
rust-lang/rust:master
from
rusticstuff:unix_remove_dir_all_opt
rusticstuff/rust:unix_remove_dir_all_opt
Copy head branch name to clipboard
Commits
Commits on Jan 30, 2022
WIP: looping version of unix remove_dir_all
cuviper
authored and
hkratz
committed
61bd4e9
View commit details
Copy full SHA for 61bd4e9
Browse repository at this point
Temporarily remove special-cased Macos x86-64 implementation.
hkratz
committed
7cf62c7
View commit details
Copy full SHA for 7cf62c7
Browse repository at this point
Readd Macos x86-64 remove_dir_all() special case using dynamic symbols.
hkratz
committed
d2cfba1
View commit details
Copy full SHA for d2cfba1
Browse repository at this point
Use limited Readdir cache and use openat(dirf, "..", O_NOFOLLOW) to go up.
hkratz
committed
93e708b
View commit details
Copy full SHA for 93e708b
Browse repository at this point
replace RawFd with BorrowedFd
hkratz
committed
424189d
View commit details
Copy full SHA for 424189d
Browse repository at this point
Store and compare with stat.st_dev as well when going back up via ..
hkratz
committed
65b740c
View commit details
Copy full SHA for 65b740c
Browse repository at this point
fix for some UNIXes: parent directory needs to be reopened after deletion of child.
hkratz
committed
12b456e
View commit details
Copy full SHA for 12b456e
Browse repository at this point
Commits on Jan 31, 2022
Add ui test for calling remove_dir_all() on deep directory hierarchies.
hkratz
committed
4641c56
View commit details
Copy full SHA for 4641c56
Browse repository at this point
test: safe depths for all platforms.
hkratz
committed
752330f
View commit details
Copy full SHA for 752330f
Browse repository at this point
Commits on Feb 2, 2022
WIP: lazy read dir datatype
hkratz
committed
bc9f33c
View commit details
Copy full SHA for bc9f33c
Browse repository at this point
refill complete cache if empty when going up
hkratz
committed
a6953a5
View commit details
Copy full SHA for a6953a5
Browse repository at this point
cosmetics
hkratz
committed
a6b94a4
View commit details
Copy full SHA for a6b94a4
Browse repository at this point
CI filesystem is apparently slow, 64K deep hierarchy takes <2sec. locally
hkratz
committed
20542dc
View commit details
Copy full SHA for 20542dc
Browse repository at this point
correct limit for readdir cache
hkratz
committed
f591d57
View commit details
Copy full SHA for f591d57
Browse repository at this point
remove debug output (oops)
hkratz
committed
266aaaf
View commit details
Copy full SHA for 266aaaf
Browse repository at this point
Commits on Feb 5, 2022
better inode reuse protection
hkratz
committed
f0bc8a6
View commit details
Copy full SHA for f0bc8a6
Browse repository at this point
expand test to include an empty dir/file in each directory
hkratz
committed
aec1f45
View commit details
Copy full SHA for aec1f45
Browse repository at this point
include parent of deletion root dir in reused inode check
hkratz
committed
dafa41f
View commit details
Copy full SHA for dafa41f
Browse repository at this point
You can’t perform that action at this time.