Skip to content

translation: lint fix + more migration - #98420

Merged
bors merged 7 commits into
rust-lang:masterfrom
davidtwco:translation-lint-fixes-and-more-migration
Jun 28, 2022
Merged

translation: lint fix + more migration#98420
bors merged 7 commits into
rust-lang:masterfrom
davidtwco:translation-lint-fixes-and-more-migration

Conversation

@davidtwco

@davidtwco davidtwco commented Jun 23, 2022

Copy link
Copy Markdown
Member
  • Unfortunately, the diagnostic lints are very broken and trigger much more often than they should. This PR corrects the conditional which checks if the function call being made is to a diagnostic function so that it returns in every intended case.
  • The rustc_lint_diagnostics attribute is used by the diagnostic translation/struct migration lints to identify calls where non-translatable diagnostics or diagnostics outwith impls are being created. Any function used in creating a diagnostic should be annotated with this attribute so this PR adds the attribute to many more functions.
  • Port the diagnostics from the rustc_privacy crate and enable the lints for that crate.

r? @compiler-errors

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2022
@compiler-errors

compiler-errors commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 73a8d42 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#98420 - davidtwco:translation-lint-fixes-an…
cc793cd 
…d-more-migration, r=compiler-errors

translation: lint fix + more migration

- Unfortunately, the diagnostic lints are very broken and trigger much more often than they should. This PR corrects the conditional which checks if the function call being made is to a diagnostic function so that it returns in every intended case.
- The `rustc_lint_diagnostics` attribute is used by the diagnostic translation/struct migration lints to identify calls where non-translatable diagnostics or diagnostics outwith impls are being created. Any function used in creating a diagnostic should be annotated with this attribute so this PR adds the attribute to many more functions.
- Port the diagnostics from the `rustc_privacy` crate and enable the lints for that crate.

r? `@compiler-errors`
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 26, 2022
Closed
@Dylan-DPC

Dylan-DPC commented Jun 26, 2022

Copy link
Copy Markdown
Member

failed in rollup ci

@Dylan-DPC

Dylan-DPC commented Jun 26, 2022

Copy link
Copy Markdown
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2022
@davidtwco

davidtwco commented Jun 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

This only failed because it was in a rollup with #98428 - these can't land at the same time, one will need to land first and then the other rebased. I'll leave this unapproved until #98428 lands.

davidtwco added 7 commits June 27, 2022 08:32
@davidtwco
lint: fix condition in diagnostic lints
871c879 
Unfortunately, the diagnostic lints are very broken and trigger much
more often than they should. Correct the conditional which checks if the
function call being made is to a diagnostic function so that it returns
in every intended case.

Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
various: add rustc_lint_diagnostics to diag fns
ae61224 
The `rustc_lint_diagnostics` attribute is used by the diagnostic
translation/struct migration lints to identify calls where
non-translatable diagnostics or diagnostics outwith impls are being
created. Any function used in creating a diagnostic should be annotated
with this attribute so this commit adds the attribute to many more
functions.

Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
privacy: port "field is private" diag
be9ebfd 
Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
privacy: port "item is private" diag
cb90a4f 
Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
privacy: port unnamed "item is private" diag
0557d02 
Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
privacy: port "in public interface" diag
74f3a96 
Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
privacy: deny diagnostic migration lints
15d61d7 
Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
davidtwco force-pushed the translation-lint-fixes-and-more-migration branch from 73a8d42 to 15d61d7 Compare June 27, 2022 07:53
@davidtwco

davidtwco commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

Rebased after #98428

@Dylan-DPC

Dylan-DPC commented Jun 27, 2022

Copy link
Copy Markdown
Member

@bors r=compiler-errors

@bors

bors commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 15d61d7 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#98420 - davidtwco:translation-lint-fixes-an…
a0a5cff 
…d-more-migration, r=compiler-errors

translation: lint fix + more migration

- Unfortunately, the diagnostic lints are very broken and trigger much more often than they should. This PR corrects the conditional which checks if the function call being made is to a diagnostic function so that it returns in every intended case.
- The `rustc_lint_diagnostics` attribute is used by the diagnostic translation/struct migration lints to identify calls where non-translatable diagnostics or diagnostics outwith impls are being created. Any function used in creating a diagnostic should be annotated with this attribute so this PR adds the attribute to many more functions.
- Port the diagnostics from the `rustc_privacy` crate and enable the lints for that crate.

r? `@compiler-errors`
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 28, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2022
@bors
Auto merge of rust-lang#98612 - Dylan-DPC:rollup-7tasikc, r=Dylan-DPC
00ebeb8 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#97346 (Remove a back-compat hack on lazy TAIT)
 - rust-lang#98261 (Remove `MAX_SUGGESTION_HIGHLIGHT_LINES`)
 - rust-lang#98337 ([RFC 2011] Optimize non-consuming operators)
 - rust-lang#98384 (Fix RSS reporting on macOS)
 - rust-lang#98420 (translation: lint fix + more migration)
 - rust-lang#98430 (Refactor iter adapters with less macros)
 - rust-lang#98555 (Hermit: Fix initializing lazy locks)
 - rust-lang#98595 (Implement `Send` and `Sync` for `ThinBox<T>`)
 - rust-lang#98597 (Remove unstable CStr/CString change from 1.62 release note)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 400f435 into rust-lang:master Jun 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 28, 2022
@davidtwco
davidtwco deleted the translation-lint-fixes-and-more-migration branch June 28, 2022 20:55
@compiler-errors compiler-errors added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 11, 2022
@davidtwco davidtwco mentioned this pull request Aug 19, 2022
Open
54 of 84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errors compiler-errors

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

6 participants

@davidtwco @compiler-errors @bors @Dylan-DPC @rust-highfive @rustbot