clippy: enable 'needless bool' checks - #7131
Closed
matthewhughes934 wants to merge 1 commit into
Closed
matthewhughes934 wants to merge 1 commit into
matthewhughes934 wants to merge 1 commit into
Conversation
These were mentioned in the original `clippy` introduction thread[1], but I left them out of the originally introduction (05840bc) because I wanted to avoid code changes there. Add them now, including the fixes they introduce. Link: rust-lang#6923 (comment) [1]
rustbot
added
A-CI
ytmimi
added
the
S-on-hold
Manishearth
approved these changes
Sep 21, 2026
rustbot
removed
the
S-waiting-on-review
Contributor
|
I'd prefer we hold off on making any |
Contributor
|
@Manishearth also, I'd like to hold off on merging PRs until after the rustfmt sync. |
Member
|
Oh, crap, for some reason I thought this was for clippy itself! My bad. |
Member
|
I was very surprised clippy itself didn't have this lint enabled |
Contributor
|
All good. We caught it 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were mentioned in the original
clippyintroduction thread[1], but I left them out of the originally introduction (05840bc) because I wanted to avoid code changes there. Add them now, including the fixes they introduce.Link: #6923 (comment) [1]