Add libs-ping group - #2755
Draft
clarfonthey wants to merge 1 commit into
Draft
Add libs-ping group#2755clarfonthey wants to merge 1 commit into
libs-ping group#2755clarfonthey wants to merge 1 commit into
Conversation
clarfonthey
force-pushed
the
libs-ping
branch
from
September 15, 2026 17:21
b9b72cb to
d3e1a88
Compare
Dry-run check results |
clarfonthey
force-pushed
the
libs-ping
branch
from
September 15, 2026 17:22
d3e1a88 to
0b6cd87
Compare
Contributor
Author
|
Ran into the reflexivity problem and forgot to include self as one of the members, hence the force-push. |
Contributor
Author
|
Also, I guess, to verify for the people who are on the review rotation who didn't express a desire to be on the FCP team or this list, to verify that you still want to be @-mentioned. Please react with a 👍 or 👎 on this comment to indicate if you want to be on the list. (I don't think we can do regular checkboxes here, since I don't think you can edit comments on this repo. Verified: |
Member
|
What volume of pings would I be signing up for here? |
Contributor
Author
|
FCPs and backports, basically. |
Amanieu
approved these changes
Sep 16, 2026
Amanieu
left a comment
Member
There was a problem hiding this comment.
LGTM! Have you updated the message from rfcbot to ping this team instead?
jieyouxu
reviewed
Sep 16, 2026
clarfonthey
force-pushed
the
libs-ping
branch
from
September 16, 2026 03:06
0b6cd87 to
93efa39
Compare
clarfonthey
marked this pull request as draft
September 16, 2026 03:07
This was referenced Sep 16, 2026
Contributor
|
Please add me as well |
clarfonthey
force-pushed
the
libs-ping
branch
from
September 16, 2026 12:49
93efa39 to
7d93552
Compare
clarfonthey
force-pushed
the
libs-ping
branch
from
September 16, 2026 14:43
7d93552 to
40c8a06
Compare
Contributor
|
I'm happy to receive pings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant discussion: #t-libs/meta > Pinging all of libs for libs FCPs
Since
lang-advisorshas a bit more meaning than just people who want to be pinged (due to the presence of a private chat), decided to just name thislibs-pingand make it only a marker group for now. Also added a comment so people are aware of who exactly should be in the group.For now, I've added:
libsleadlibs-fcpteamrust-lang/rust(note: waiting on below)Which should be sufficient for now.