Skip to content

Update tests to 1.88.0 to accommodate BLAS testing requirements #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quietlychris merged 5 commits into from
Aug 22, 2026
Merged

Update tests to 1.88.0 to accommodate BLAS testing requirements #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3b4f0f
Update tests to 1.88.0 to accommodate BLAS testing requirements
quietlychris Aug 22, 2026
c8eea4a
Update to 1.88.0 for both standard tests and BLAS
quietlychris Aug 22, 2026
fad83af
Remove unnecessary dataset lifetime to make clippy happy
quietlychris Aug 22, 2026
e0ab238
Apply clippy suggestion in linfa-lars re: late allocation
quietlychris Aug 22, 2026
f459777
cargo fmt
quietlychris Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checking.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fail-fast: false
matrix:
toolchain:
- 1.87.0
- 1.88.0
- stable
- nightly
os:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fail-fast: false
matrix:
toolchain:
- 1.87.0
- 1.88.0
- stable
os:
- ubuntu-latest
Expand All @@ -37,7 +37,7 @@ jobs:
fail-fast: false
matrix:
toolchain:
- 1.87.0
- 1.88.0
- stable
os:
- ubuntu-latest
Expand Down
9 changes: 4 additions & 5 deletions algorithms/linfa-lars/src/algorithm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,15 @@ fn lars_path<F: Float>(
}

loop {
let c;
let mut c_idx = 0;
let mut c_ = F::zero();
if !cov.is_empty() {
let c = if !cov.is_empty() {
c_idx = cov.abs().argmax().unwrap();
c_ = cov[c_idx];
c = c_.abs();
c_.abs()
} else {
c = F::zero();
}
F::zero()
};

let mut alpha = alphas.slice(s![n_iter, NewAxis]).to_owned();
let mut coef = coefs.row(n_iter).to_owned();
Expand Down
4 changes: 2 additions & 2 deletions src/dataset/impl_dataset.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ where
where
ER: std::error::Error + std::convert::From<crate::error::Error>,
M: for<'c> Fit<ArrayView2<'c, F>, ArrayView<'c, E, I>, ER, Object = O>,
O: for<'d> PredictInplace<ArrayView2<'a, F>, Array<E, I>>,
O: PredictInplace<ArrayView2<'a, F>, Array<E, I>>,
FACC: Float,
C: Fn(
&Array<E, I>,
Expand Down Expand Up @@ -1061,7 +1061,7 @@ where
where
ER: std::error::Error + std::convert::From<crate::error::Error>,
M: for<'c> Fit<ArrayView2<'c, F>, ArrayView1<'c, E>, ER, Object = O>,
O: for<'d> PredictInplace<ArrayView2<'a, F>, Array1<E>>,
O: PredictInplace<ArrayView2<'a, F>, Array1<E>>,
FACC: Float,
C: Fn(&Array1<E>, &ArrayView1<E>) -> std::result::Result<FACC, crate::error::Error>,
{
Expand Down
Loading