Repository navigation
fix: Add #[track_caller] to many address, page, and frame methods - #615
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of
#[track_caller]attributes to creation and arithmetic onVirtAddr,PhysAddr,Page, andFrame. This makes Rust panic messages point to the problematic user code (or higher-level code in this crate) instead of the code that is expected to panic on certain inputs.Example:
Before:
After (my kernel):
This is very useful for debugging issues such as #611 but is also useful in general for users.
There might be more places where
#[track_caller]might make sense, but these should be the obvious ones.