Conversation
The CI only checked docs warnings on the `winit` crate which is the only default emember of the workspace. Added the `--worksace` flag to check documentation on all the member. Adding a `#[cfg(doc)] use ...` only work within a single crate (eg winit-core), but when re-exported items are documented in the winit crate itself, it doesn't work. Removing link to `ActiveEventLoop::request_activation_token` that no longer exist. Fiw the winit-web docs that were still trying to reference things in `crate::` instead of `winit_core::`
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI only checked docs warnings on the
winitcrate which is the only default emember of the workspace. Added the--worksaceflag to check documentation on all the member.Adding a
#[cfg(doc)] use ...only work within a single crate (eg winit-core), but when re-exported items are documented in the winit crate itself, it doesn't work.Removing link to
ActiveEventLoop::request_activation_tokenthat no longer exist.Fiw the winit-web docs that were still trying to reference things in
crate::instead ofwinit_core::