Skip to content

Dev/update version and notes - #223

Merged
chifflier merged 20 commits into
masterfrom
dev/update-version-and-notes
Jul 22, 2026
Merged

Dev/update version and notes#223
chifflier merged 20 commits into
masterfrom
dev/update-version-and-notes

Conversation

@chifflier

Copy link
Copy Markdown
Member

Misc changes to prepare first beta release (which will be 0.19.0-beta.1):

  • Fix version number in CHANGELOG and UPGRADING files (closes UPGRADING file does not seem to apply #222)
  • Update version to 0.19.0-beta.1
  • chore(cargo): update dependencies time and thiserror
    • note that time depends on time-core which unfortunately requires rust 1.81, which explains the next commits
    • compatibility with our current MSRV is still possible by using a --precise flag with cargo update
  • Clarify MSRV policy in README
  • switch to cargo rdme, add CI checks and update links
    • this helps maintaining src/lib.rs and README.md in sync

@chifflier
chifflier requested a review from cpu September 8, 2025 09:55
@chifflier

Copy link
Copy Markdown
Member Author

@cpu ping? I do not mean to hurry. I totally understand if you do not have time, just tell me :)

@cpu

cpu commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the ping and sorry for letting it sit without a reply! I'm a bit more over-subscribed than usual this week and probably won't have a chance to look at it until ~next. You don't have to wait for me of course if that's too long to wait.

@dns2utf8

dns2utf8 commented Dec 5, 2025

Copy link
Copy Markdown

Quick question, is the code in this PR what landed in the 0.18 release?

Thank you all

@chifflier

Copy link
Copy Markdown
Member Author

Hi @cpu,
Gentle ping for this PR review

Quick question, is the code in this PR what landed in the 0.18 release?
Yes (and more). This is mostly merging the entry for 0.18.0 in CHANGELOG.md, and then bumping version for master (next release planned is 0.19.0-beta.1)

@cpu cpu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping and apologies for letting this fall off my radar! Here's some initial feedback.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md
@chifflier

Copy link
Copy Markdown
Member Author

Ok, so, I do not really like that but I had to include a few other changes in the PR to fix urgent problems and attempt to have a cleaner CI
There is still an issue with cargo-rdme and nightly version. Geez, this is annoying

@chifflier

Copy link
Copy Markdown
Member Author

Ok, so, cargo-rdme pushed a fix/workaround, so everything should be fine now! CI is green 🎉
@cpu : would you have some time to review this? This PR is blocking several others and it is becoming urgent
Thanks in advance

@cpu cpu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done an extensive review but I think given how long this has been blocked it makes sense to merge + iterate if anything new pops up.

Comment thread src/validate/extensions.rs Outdated
Comment thread src/validate/structure.rs Outdated
Comment thread .github/workflows/rust.yml
@chifflier

Copy link
Copy Markdown
Member Author

Thank you for the quick review!
I will now merge changes (including a revert to MSRV 1.85 as discussed) and close this
Let's use other issues/PRs if there is anything to discuss

@chifflier
chifflier merged commit ef60a63 into master Jul 22, 2026
40 checks passed
@chifflier
chifflier deleted the dev/update-version-and-notes branch July 22, 2026 07:48
@cpu

cpu commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Great! Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UPGRADING file does not seem to apply

3 participants