Replace once_cell with std::sync::OnceLock - #257
Merged
Merged
Conversation
FalkWoldmann
force-pushed
the
replace-once-cell
branch
from
September 30, 2026 19:59
759932b to
7ba4429
Compare
Member
|
I fixed the unrelated CI issues in Can you rebase on top of current |
OnceLock::get_or_try_init isn't stable yet, so values are built before being stored.
FalkWoldmann
force-pushed
the
replace-once-cell
branch
from
October 1, 2026 07:36
7ba4429 to
7763deb
Compare
complexspaces
approved these changes
Oct 1, 2026
Contributor
Author
|
Rebased, thanks! |
Collaborator
|
Re the SemVer job failing: It seems really unlikely anyone enabled the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnceLock has been in std since Rust 1.70, below the MSRV of 1.85. zget_or_try_init zisn't stable on OnceLock yet, so the two places that used it now build the value first and store it with set/get_or_ini t