Fix ComplexConjugateControl reactive-gain sign error (K_r double-negative) - #10
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix the Complex-Conjugate Control reactive-gain sign error
Fix ComplexConjugateControl reactive-gain sign error (K_r double-negative)
Jul 8, 2026
salhus
marked this pull request as ready for review
July 8, 2026 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComputeCCGainscomputedK_r = −ω²(I+A) + K_hs, which combined with the control lawτ = −K_r·θyieldedτ_react = +(ω²(I+A) − K_hs)·θ— the wrong sign. The reactive torque reinforced the flap's reactance instead of cancelling it, causing ±0.92 rad runaway amplitude and negative mean absorbed power.Changes
src/impedance.cpp—ComputeCCGains(one-line fix + explanatory comment):src/impedance.h,src/active_pto.h,docs/CONTROLLERS.md— updatedK_rformula in all doc comments/gain-derivation blocks to reflect the corrected sign.ComplexConjugateControl::ComputeForce, all other controllers (passive,opt_passive,exc_ff_pid),PitchImpedanceMagnitude, and the CSV schema are unchanged.