Fix one-timestep logging skew and document GetTorque() sign convention - #5
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix per-step logging bug in simulation loops
Fix one-timestep logging skew and document GetTorque() sign convention
Jul 8, 2026
salhus
marked this pull request as ready for review
July 8, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-step CSV logging in
demo_vgoswec.cppmixed pre-step kinematics with post-step torque/time, skewing every row by one timestep (~0.005 s) and makingpower_w = -tau*omegaincorrect. Both the GUI (ui.IsRunning) and headless loops had identical bugs.Changes (
src/demo_vgoswec.cpponly)rsda->GetAngle()/rsda->GetVelocity()to afterDoStepDynamics, grouping all four logged reads post-step:rsda->GetTorque()documenting the expected sign perdocs/CONTROLLERS.md(positive torque opposes positive θ;P_abs = −τ·ω) and the passive-run validation:pto_torque_nmshould carry the opposite sign toflap_pitch_vel_rads, yielding net-positivepower_w. No preemptive negation — comment only.