Skip to content

Fix Chrono 10 RSDA functor override and GUI static link ordering - #6

Merged
salhus merged 3 commits into
mainfrom
copilot/fix-evaluate-override-error
Jul 8, 2026
Merged

Fix Chrono 10 RSDA functor override and GUI static link ordering#6
salhus merged 3 commits into
mainfrom
copilot/fix-evaluate-override-error

Conversation

Copilot AI commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

RsdaPtoFunctor was still using the pre-Chrono-10 ChLinkRSDA::TorqueFunctor::evaluate signature, so the override failed to compile once rsda_pto_functor.cpp was built. In the same build path, demo_vgoswec could also fail at link time because libseastack_app_lib.a was linked before the Chrono VSG / VSG / ImGui libraries it depends on.

  • RSDA functor signature

    • Update RsdaPtoFunctor::evaluate in both declaration and definition to match Chrono 10:
      evaluate(time, rest_angle, angle, vel, link)
    • Keep the existing angle -> displacement, vel -> velocity, time -> time mapping into ComputeForce
    • Mark rest_angle unused and document that it is part of the Chrono 10 callback shape, not part of the PTO model inputs
  • GUI/static-library link resolution

    • Reorder demo_vgoswec link inputs so SEAStack::app_lib appears before its Chrono VSG / VSG / ImGui dependencies
    • Collect GUI libraries into a single trailing group to satisfy left-to-right static link resolution
    • Accept both namespaced and non-namespaced vsgXchange / vsgImGui targets where exported that way
double evaluate(double time,
                double rest_angle,
                double angle,
                double vel,
                const ::chrono::ChLinkRSDA& link) override;

Copilot AI changed the title [WIP] Fix override error in RsdaPtoFunctor evaluate method Fix Chrono 10 RSDA functor override and GUI static link ordering Jul 8, 2026
Copilot AI requested a review from salhus July 8, 2026 00:21
Copilot finished work on behalf of salhus July 8, 2026 00:21
@salhus
salhus marked this pull request as ready for review July 8, 2026 00:21
@salhus
salhus merged commit da845d0 into main Jul 8, 2026
@salhus
salhus deleted the copilot/fix-evaluate-override-error branch July 8, 2026 00:21
Copilot stopped work on behalf of salhus due to an error July 8, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants