Fix Chrono 10 RSDA functor override and GUI static link ordering - #6
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix override error in RsdaPtoFunctor evaluate method
Fix Chrono 10 RSDA functor override and GUI static link ordering
Jul 8, 2026
salhus
marked this pull request as ready for review
July 8, 2026 00:21
Copilot stopped work on behalf of
salhus due to an error
July 8, 2026 00:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RsdaPtoFunctorwas still using the pre-Chrono-10ChLinkRSDA::TorqueFunctor::evaluatesignature, so the override failed to compile oncersda_pto_functor.cppwas built. In the same build path,demo_vgosweccould also fail at link time becauselibseastack_app_lib.awas linked before the Chrono VSG / VSG / ImGui libraries it depends on.RSDA functor signature
RsdaPtoFunctor::evaluatein both declaration and definition to match Chrono 10:evaluate(time, rest_angle, angle, vel, link)angle -> displacement,vel -> velocity,time -> timemapping intoComputeForcerest_angleunused and document that it is part of the Chrono 10 callback shape, not part of the PTO model inputsGUI/static-library link resolution
demo_vgosweclink inputs soSEAStack::app_libappears before its Chrono VSG / VSG / ImGui dependenciesvsgXchange/vsgImGuitargets where exported that way