Fix ps.psaux and ps.lsof to raise CommandNotFoundError when binaries are missing#69814
Open
twangboy wants to merge 1 commit into
Open
Fix ps.psaux and ps.lsof to raise CommandNotFoundError when binaries are missing#69814twangboy wants to merge 1 commit into
twangboy wants to merge 1 commit into
Conversation
…are missing On Windows, ps.psaux crashed with a raw WinError traceback because it shells out to `ps aux` with no guard. Add the same @path.which decorator already used by ps.netstat and ps.ss so both psaux and lsof fail with a clear CommandNotFoundError instead. Fixes saltstack#65252
twangboy
force-pushed
the
fix/65252/3006.x
branch
from
July 16, 2026 01:24
ce3f2fb to
49a8b4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Windows, ps.psaux crashed with a raw WinError traceback because it shells out to
ps auxwith no guard. Add the same @path.which decorator already used by ps.netstat and ps.ss so both psaux and lsof fail with a clear CommandNotFoundError instead.What issues does this PR fix or reference?
Fixes #65252
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes