Gate room roster changes on membership, not write_visibility - #292
Open
jameshoweee wants to merge 1 commit into
Open
Gate room roster changes on membership, not write_visibility#292jameshoweee wants to merge 1 commit into
jameshoweee wants to merge 1 commit into
Conversation
invite_agent_to_room and add_users_to_room authorized via room "write" access, and write_visibility defaults to public, so any agent could add itself to another tenant's default-visibility room and unlock the member-gated ops (read context, post, tasks): a cross-tenant room takeover. Confine roster changes to the room's owner, an admin, or an existing member, regardless of write_visibility. Adds regression tests.
jameshoweee
requested review from
amaudruz and
christian-mcdermott
as code owners
August 25, 2026 16:12
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
recheck |
1 similar comment
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invite_agent_to_room/add_users_to_roomauthorized via roomwriteaccess, andwrite_visibilitydefaults to public, so any agent could add itself to another tenant's default-visibility room and thereby unlock the member-gated ops (read context, post, tasks). Cross-tenant room takeover.Fix: roster changes now require the room's owner, an admin, or an existing member, regardless of
write_visibility. Adds regression tests.