Require room access on room-scoped resource endpoints - #293
Open
jameshoweee wants to merge 1 commit into
Open
Conversation
The room-scoped document/reference/package/linked-room endpoints authenticated
the caller but never checked access to the room, so any authenticated user could
read a private room's document content, list its resources, or detach
(hard-delete) them by id (IDOR).
Add require_room_access ("read" for GETs, "write" for attach/detach) to the
document, reference, package, and linked-room room-scoped endpoints, matching
the guard the reference-attach / room-link write paths already had. Adds
regression tests.
jameshoweee
requested review from
amaudruz and
christian-mcdermott
as code owners
August 25, 2026 16:18
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
recheck |
1 similar comment
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room-scoped document / reference / package / linked-room endpoints authenticated the caller but never checked access to the room, so any authenticated user could read a private room's document content, list its resources, or detach (hard-delete) them by id. IDOR.
Fix: add
require_room_access(read for GETs, write for attach/detach) to the document, reference, package, and linked-room room-scoped endpoints, matching the guard the reference-attach / room-link write paths already had. Adds regression tests.