fix(db,clients): declare the undeclared indexes, type the untyped kwargs (CHOO-1436)

[amaudruz]

Two outstanding items from the Tuwunel-replacement work, neither of them part of a plan step. Stacked on #366.

The four undeclared indexes — afa45e2d

ix_agent_sessions_agent_room, ix_agent_sessions_transport_session_id, ix_agents_parent_agent_id and ix_external_user_claims_user_id were created by migrations and never declared on the models. Autogenerate would have emitted DROP INDEX for all four — so the next person to add a column had a one-keystroke path to quietly dropping four indexes off live tables.

The parity test listed them by name rather than filtering by kind, precisely so this stayed visible rather than becoming permanent. The list goes with them, and the test is back to allowing no drift at all.

The constructor pass-through — 443cfb97

Four ClientBase subclasses forwarded their remaining arguments as **kwargs: Any (**kwargs: object plus a type: ignore on AgentClient). That makes the pass-through invisible to the type checker in both directions: the subclass cannot be told it is missing something, and a caller cannot be told it is passing something that no longer exists.

Which is how a stale device_id= type-checked clean and took all four collaboration bridges down at startup. The credential had moved into session_state, and nothing said so until the process refused to start.

ClientBaseKwargs declares the shape once and the subclasses Unpack it, so both checks come back without eleven parameters restated four times.

Verified by putting the original mistake back. With device_id=record.device_id re-added at the factory call site, mypy reports:

core/switch_core/clients/client_factory.py:69: error: Unexpected keyword argument "device_id" for "ClientBase"  [call-arg]

matrix_transport_for widens to ClientBase[Any], which is what it always was in fact — it reads five base attributes and never the config. ClientBase is invariant in its config type, so the previous annotation only type-checked while nobody was checking.

Testing

2355 pass, ruff and mypy clean.

🤖 Generated with Claude Code