fix(console): report an unusable remote working directory before minting (CHOO-1416)

[abeldantas]

Context

• This is the fix from fix(switchdash): report a missing remote working directory instead of failing at write time (CHOO-1416) #137 ported to current main (that branch predates the dash-to-console rename);

That branch had a bunch of dead code and got sort of deprecated.

Summary

• Creating a remote agent no longer strands a gateway identity when the working directory's parent doesn't exist: the directory is checked before anything is minted, and the refusal names the path and the host instead of a raw FileSystemError.
• inspectRemoteDir decides in two stats from a host-rooted fs: directory and creatable (missing leaf, parent exists) proceed exactly as before; file and missing are refused up front.
• The sandbox boundary in SshFileSystem is untouched: an fs rooted at a working directory still cannot create that directory's ancestors — the fix is ordering, not permission.

[Copilot]

🟡 Changes recommended

The new missing status is documented and messaged as “parent doesn’t exist,” but it can also mean “parent exists but is a file,” producing incorrect user-facing guidance.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR improves the remote-agent creation flow in Switch Console by validating a remote agent’s working directory before minting a gateway identity, preventing orphaned Switch-side agents when the directory is unusable.

Changes:

• Introduces a shared remote working-directory inspection model (RemoteDirInspection) plus a usability predicate (isUsableRemoteDir).
• Adds a main-process SSH-based inspectRemoteDir() check and wires it into addAgent ahead of identity registration, returning a typed directory-missing failure.
• Extends renderer error handling and telemetry enums to represent the new failure mode, with tests covering the new behavior.

File summaries

File	Description
console/apps/switch-console-desktop/src/shared/core/switch-servers/switch-servers.ts	Extends shared provisioning result union with a typed directory-missing failure payload.
console/apps/switch-console-desktop/src/shared/core/remote-hosts/remote-dir.ts	Adds shared inspection/status types and a helper to decide if a remote dir is usable.
console/apps/switch-console-desktop/src/renderer/features/locations/components/add-agent-modal/add-agent-modal.tsx	Surfaces directory-missing as a user-facing toast in the add-agent modal.
console/apps/switch-console-desktop/src/main/core/telemetry/events.ts	Adds directory_missing as a structured failure reason for agent creation telemetry.
console/apps/switch-console-desktop/src/main/core/agents/remote-dir.ts	Implements inspectRemoteDir() via an SSH filesystem rooted at / to inspect the target dir and its parent.
console/apps/switch-console-desktop/src/main/core/agents/remote-dir.test.ts	Adds focused unit tests for all inspection outcomes and error/cleanup behavior.
console/apps/switch-console-desktop/src/main/core/agents/add-agent.ts	Performs the remote dir inspection before minting and returns directory-missing when unusable.
console/apps/switch-console-desktop/src/main/core/agents/add-agent.test.ts	Verifies refusal happens before minting and that local adds don’t probe SSH.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.