Skip to content

Add dependabot and pin node dependencies #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
palemieux merged 2 commits into from
Sep 3, 2026
+50 −80
Merged

Add dependabot and pin node dependencies #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a20eb
Add dependabot
palemieux Sep 2, 2026
de35c33
Address feedback at https://github.com/sandflow/imscJS/pull/271#discu…
palemieux Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
version: 2
updates:
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "weekly"

@nigelmegitt nigelmegitt Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means it will check weekly, but during that check, it might update a dependency to a release made only hours ago. If you want to avoid supply chain attacks, setting a longer cooldown period would mean that, during the check, it will only apply updates that are at least as old as that cooldown period. By setting the cooldown period to e.g. 7 days (which is what we use in BBC) that gives the rest of the ecosystem that long to identify and address any "bad" releases. I'd recommend doing that.

@palemieux palemieux Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See de35c33

cooldown:
default-days: 7
semver-major-days: 14
semver-minor-days: 7
semver-patch-days: 7
versioning-strategy: 'increase'
82 changes: 20 additions & 62 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 18 additions & 18 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,25 @@
"test": "node --test ./src/test/js/*Test.js"
},
"dependencies": {
"tslib": "^2.6.2"
"tslib": "2.8.1"
},
"devDependencies": {
"@eslint/js": "^9.39.5",
"@rollup/plugin-commonjs": "^29.0.3",
"@rollup/plugin-node-resolve": "^16.0.3",
"@rollup/plugin-terser": "^1.0.0",
"eslint": "^9.39.5",
"filesaver.js-npm": "latest",
"globals": "^17.11.0",
"grunt": "latest",
"grunt-contrib-clean": "latest",
"grunt-exec": "^3.0.0",
"grunt-npmcopy": "latest",
"grunt-sync": "latest",
"jszip": "latest",
"rollup": "^4.14.3",
"rollup-plugin-polyfill-node": "^0.13.0",
"sax": "^1.6.1",
"typescript": "^5.4.5"
"@eslint/js": "9.39.5",
"@rollup/plugin-commonjs": "29.0.3",
"@rollup/plugin-node-resolve": "16.0.3",
"@rollup/plugin-terser": "1.0.0",
"eslint": "9.39.5",
"filesaver.js-npm": "1.0.1",
"globals": "17.11.0",
"grunt": "1.6.3",
"grunt-contrib-clean": "2.0.1",
"grunt-exec": "3.0.0",
"grunt-npmcopy": "0.2.0",
"grunt-sync": "0.8.2",
"jszip": "3.10.1",
"rollup": "4.63.1",
"rollup-plugin-polyfill-node": "0.13.0",
"sax": "1.6.1",
"typescript": "5.9.3"
}
}
Loading