fix(mir): evaluate singleton sort keys exactly once - #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A singleton
sort_by_keyskipped its key callable, losing effects required by the exactly-once contract. Keyed nonempty inputs now use the ordinary decoration and cleanup path; empty inputs invoke no key.Validation: the new tiny-input trace regression fails on the previous compiler and covers integer, float, borrowed-string and captured keys before and after filtering. The sort owners, bounded gate and Clippy pass; the tiny-input owner also runs with adaptive sorting disabled.