feat: borrow slices of existing Move records and strings - #1013
Merged
Conversation
Closure-Matrix-Reopened: complete-nested-projection-paths
sanohiro
marked this pull request as ready for review
September 10, 2026 04:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrowed slices of existing AoS Move records and owned strings now support ordinary view formation, leaf projection, and explicitly shared indexed calls. For example, a slice of records containing owned strings can read
view[i].inner.textasstrwithout loading or copying an intermediate Move record. Whole Move-element reads and unrelated owning collection domains remain rejected.The implementation preserves backing-storage lifetime and separately reserves the slice header through eager call operands. Nested indexed projections carry complete field paths through MIR, provenance validation, LLVM physical layout and cache text. Malformed inline paths reject before emission, including scalar-result paths outside ownership-graph demand. An existing fixed-array resource borrow classifier mismatch is also corrected against its original cleanup regression.
Validation: six parameterized whole/per-unit Move-slice owners cover formation, nested layouts, shared helpers, source/header invalidation, eager control, allocation/Drop negative controls and cache edits; HIR/MIR mutation owners cover all public entrypoints. Existing borrowed parameters, temporary owners, struct indexing, m5 and fixed-record template resource tests pass. Independent full-diff review findings are closed by the recorded correction; final preflight runs the owner, bounded gate and Clippy.
This implements R67 under plan 44. align-llm adoption and product acceptance remain consumer-owned.