prompts: handle Runtime PM conditional gets - #422
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Member
|
LGTM, but it's in a draft state, should I move on and merge it? Or there is something to wait for? |
OllieinCanada
marked this pull request as ready for review
August 12, 2026 19:35
Contributor
Author
|
Thanks! Nothing else is pending from my side. I have marked the PR ready for review; please feel free to merge it. |
Member
|
Cool, thanks! |
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
OllieinCanada
force-pushed
the
fix/396-runtime-pm-prompt
branch
from
August 14, 2026 18:12
a10a6ab to
2b2b856
Compare
Contributor
Author
|
Updated the commit with my real author and Signed-off-by identity. DCO, lint, and unit tests are all green, and nothing else is pending from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #396
Summary
Teach Sashiko's power-management prompt to account for the configuration-dependent return contract of
pm_runtime_get_if_active()andpm_runtime_get_if_in_use().Root cause
With
CONFIG_PM=n, these helpers return a negative stub value while Runtime PM put operations are no-ops. Treating every negative return as an error that requires an early return can incorrectly suppress hardware operations in kernels built without Runtime PM.Changes
CONFIG_PM=yret <= 0unconditionallyValidation
cargo fmt --all -- --checkgit diff --check