prompts: verify cross-function resource cleanup - #425
Draft
OllieinCanada wants to merge 1 commit into
Draft
Conversation
Signed-off-by: OllieinCanada <73385593+OllieinCanada@users.noreply.github.com>
OllieinCanada
marked this pull request as ready for review
August 12, 2026 20:22
Member
|
This look reasonable to me, but do you have any examples or stats on how it helps in practice? Any specific false positives it helps to avoid? I strongly prefer to make prompts changes based on data. |
OllieinCanada
marked this pull request as draft
August 14, 2026 15:31
Contributor
Author
|
I don't have aggregate stats. The source is #124, but that report doesn't include the affected patchset, code, or exact false-positive output. I agree that isn't enough evidence for a confident prompt change, so I've moved this back to draft and asked for a concrete reproducer before taking it further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124
Summary
Require Sashiko to inspect cleanup helper implementations before reporting a cross-function resource leak.
Root cause
The resource-management prompts required ownership tracking across function boundaries, but the final false-positive verification did not explicitly require opening cleanup, unwind, destroy, unregister, or release helpers. A call site could therefore appear to leak a resource even when a conditional helper released it internally.
Changes
Validation
cargo fmt --all -- --checkgit diff --checkNo model-backed regression or paid API call was used.