db: make outbox inserts atomic - #435
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Outbox deduplication used separate lookup and insert queries. Concurrent review completions could both observe no row and enqueue duplicate notifications. Use conditional inserts so the existence check and write are atomic. Cover review email, Patchwork update, and Patchwork notification paths with concurrent-writer tests. Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
OllieinCanada
marked this pull request as ready for review
August 15, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Sashiko's notification outboxes idempotent under concurrent review completion.
Root cause
Each outbox writer first queried for an existing row and then issued a separate insert. Two review tasks completing together could both observe that no row existed before either insert ran, allowing duplicate external notifications to be queued.
The code described these paths as duplicate-safe, but the invariant was not enforced atomically at the persistence boundary.
Design
Each writer now uses a single
INSERT ... SELECT ... WHERE NOT EXISTSstatement. SQLite/libSQL serializes the conditional check and write as one statement, closing the check-then-act window without a schema migration or destructive cleanup of historical outbox rows.The existing logical deduplication keys remain unchanged:
Validation
rustfmt --checkpasses forsrc/db.rsgit diff --checkpassescargo testandmake check-prstop before compiling Sashiko becauseaws-lc-sysrejects the installed GCC 9.4 compiler; GitHub CI is expected to provide the authoritative Rust, clippy, and test results