Skip to content

fix(core): validate YAML golden output - #6171

Closed
ousamabenyounes wants to merge 1 commit into
scaleway:mainfrom
ousamabenyounes:fix/issue-5184
Closed

ousamabenyounes wants to merge 1 commit into
scaleway:mainfrom
ousamabenyounes:fix/issue-5184

Conversation

@ousamabenyounes

Copy link
Copy Markdown

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, as they generate extra noise for pull request followers and do not help prioritize the request.

Closes #5184

Summary

  • render and validate YAML stdout and stderr in the golden-test harness alongside JSON
  • preserve custom JSON marshaling when YAML-printing CLI errors, including empty errors
  • regenerate the affected golden snapshots and normalize temporary config paths in YAML

Test verification (RED → GREEN)

  • RED: the focused test fails on upstream main because YAML sections are absent; the empty CliError case also exposes the YAML-printer panic
  • GREEN: all three focused YAML golden cases pass with this patch
  • full local suite: mise run ci (2,604 Go tests passed, 17 existing skips; 9 WASM tests passed; all build and lint tasks passed)
  • changed-line coverage: 100% (37/37 production lines)
  • reverting the production patch makes all three focused YAML golden cases fail
NONE

@ousamabenyounes
ousamabenyounes requested review from a team and remyleone as code owners September 10, 2026 04:12
@github-actions github-actions Bot added registry Managed Container Registry issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests iot IoT issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests iam IAM issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests baremetal labels Sep 10, 2026
@ousamabenyounes
ousamabenyounes force-pushed the fix/issue-5184 branch 2 times, most recently from b76b0df to 1a94d1d Compare September 10, 2026 16:21
@elwinar

elwinar commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This is neither a bug, nor a feature we're interested in at this time.

@elwinar elwinar closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apple-silicon Apple Silicon issues, bugs and feature requests baremetal container Container issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for testing YAML output in the CLI

2 participants