feat(core): autocomplete srn arguments on create commands - #6178
Open
ousamabenyounes wants to merge 1 commit into
Open
feat(core): autocomplete srn arguments on create commands#6178ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
ousamabenyounes
force-pushed
the
fix/issue-5807
branch
from
September 11, 2026 10:22
1c08c1f to
7e1e79b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic argument autocompleter skipped any create-verb argument sharing the command's resource name, which silently disabled completion of
srnarguments (e.g.scw annotations binding create srn=<tab>). Ansrnargument references a foreign, pre-existing resource by its Scaleway Resource Name rather than the resource being created, so it is now exempted from that skip and completed from the resource's list verb.Test verification (RED → GREEN)
With the fix reverted, the new test fails (RED):
With the fix applied, the test passes (GREEN):
Full local suite
Command:
export PATH="/home/ousama/.local/share/go-1.26.6/go/bin:$PATH" GOTOOLCHAIN=auto; go build ./... && go test ./core/...Fix #5807