fix(codegen): prevent discriminator variant merging with original model - #144
Merged
kudlatyamroth merged 1 commit intoAug 27, 2026
Conversation
When --merge-similar-models is enabled, the modified oneOf variant (with the discriminator field removed) was merged back into the original referenced model because both shared the same schema_hash. Clear the schema_hash after mutating the variant so it is treated as a distinct model and the generated internally tagged enum no longer requires the discriminator field on each variant.
kudlatyamroth
deleted the
bugfix/merge-similar-and-swagger-discriminator
branch
August 27, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --merge-similar-models is enabled, the modified oneOf variant (with the discriminator field removed) was merged back into the original referenced model because both shared the same schema_hash. Clear the schema_hash after mutating the variant so it is treated as a distinct model and the generated internally tagged enum no longer requires the discriminator field on each variant.