fix(ship): PR body template slot for permanent-test admission decisions - #544
Merged
Conversation
…e slot Second reading of CC-554's admission-recording rule (effective since pr:#530): across a 12-PR evidence window, both qualifying instances found (pr:#539's 7 new regression cases, pr:#541's 2 new test functions) added a permanent test as a gate-finding remedy but recorded zero admission-criteria citations in the PR body. The rule text lives in Step 2.5, several screens before the PR body actually gets composed in Step 4 -- a free-floating prose reminder read once during remediation is not reliably recalled by the time the PR body template gets filled in. Add an explicit `Permanent test admissions:` field to that template so its omission is conspicuous (fill it in, or write `none`) instead of silent, and add a regression assertion that the template carries the field. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177ds9nxEMtsh3bwpBxNHYx
Two gate reviewers (critic, architecture-reviewer) independently flagged that the template's `| none` fallback read as usable whenever no new permanent test was added -- including a round whose finding was resolved via a recorded alternative, which Step 2.5 still requires a line for. Reworded so `none` applies only when no finding this round was assessed against Step 2.5 at all, and added regression assertions for both the alternative-path requirement and the none-is-not-a-substitute wording. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177ds9nxEMtsh3bwpBxNHYx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Permanent test admissions:field, so omission is conspicuous (fill it in, or writenone) instead of silent.nonestand in for an alternative-path finding's own record, not only for "no qualifying finding at all". Reworded sononeapplies only when no finding this round needed the Step 2.5 assessment, and every assessed finding — admitted or resolved by an alternative — still needs its own line.Test plan
bash tests/shell/test-commands.sh(318/318, including 3 new assertions on the template's admission-record field and its none-vs-alternative wording)tools/lint/lint-shellcheck.shclean on the whole repopmctl gate run --executor codex --policy generic→ GO (round 1 real finding fixed: none-wording ambiguity flagged independently by critic and architecture-reviewer; round 2 hit an executorapply_patchprotocol failure, re-ran to GO)tests/bin/run-all-tests.sh→ 104 passed, 0 failed, 0 skipped🤖 Generated with Claude Code
https://claude.ai/code/session_0177ds9nxEMtsh3bwpBxNHYx