Conversation
Contributor
|
This is already fixed in #95, I'll backport it from there to avoid conflicts when rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arbitrary UTCTimechose a day time between 0 and 86401 seconds, andArbitrary TimeOfDaychose seconds between 0 and 60. A value at or above the limit is a leap second, e.g.23:59:60. PostgreSQL has no leap seconds and moves such a time to00:00:00on the next day. The returned day then differs from the sent day, and the test fails:About one value in 86400 fell into this range. Each run makes 1000 values, so about one run in 80 failed. CI reported it twice.
The generators now stop at 86399.999999 seconds and at 59.999999 seconds.
LocalTimeandZonedTimebuild onTimeOfDay, so the fix covers them too.