Skip to content

Allow SPU cache custom calls in dynamic export - #418

Merged
FollyCoolly merged 1 commit into
mainfrom
zhsu/cache_call_export
Jun 26, 2026
Merged

Allow SPU cache custom calls in dynamic export#418
FollyCoolly merged 1 commit into
mainfrom
zhsu/cache_call_export

Conversation

@FollyCoolly

Copy link
Copy Markdown
Contributor

Summary

  • allow SPU cache custom calls during dynamic-shape JAX export
  • add a regression test for make_cached_var/drop_cached_var in SPU dynamic compile

Tests

  • uv run ruff check mplang/dialects/spu.py tests/backends/test_spu_impl.py
  • uv run pytest tests/backends/test_spu_impl.py

@FollyCoolly
FollyCoolly requested a review from a team as a code owner June 26, 2026 05:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SPU dialect compilation settings to disable checks for spu.make_cached_var and spu.drop_cached_var during JAX export. It also adds a corresponding test case test_spu_dynamic_shape_allows_cache_custom_calls to verify that SPU-owned cache custom calls are allowed with dynamic shapes. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@danqi437 danqi437 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FollyCoolly
FollyCoolly merged commit b8adf43 into main Jun 26, 2026
11 checks passed
@FollyCoolly
FollyCoolly deleted the zhsu/cache_call_export branch June 26, 2026 09:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants