[feat] support SPU link_desc config - #419
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces SPULinkDesc to support custom BRPC link configurations within SPUConfig, allowing per-SPU link descriptions to be merged over default configurations in SPUState. It also updates the runtime cache key to include fxp_fraction_bits and the new BRPC configuration, and adds comprehensive unit tests. The review feedback suggests adding defensive type checks in the from_dict methods of both SPULinkDesc and SPUConfig to gracefully handle malformed inputs and prevent potential AttributeErrors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
No description provided.