Skip to content

feat: support SPU profiling config - #420

Merged
FollyCoolly merged 2 commits into
mainfrom
zhsu/spu-profiling
Jul 13, 2026
Merged

feat: support SPU profiling config#420
FollyCoolly merged 2 commits into
mainfrom
zhsu/spu-profiling

Conversation

@FollyCoolly

Copy link
Copy Markdown
Contributor

No description provided.

@FollyCoolly
FollyCoolly requested a review from a team as a code owner July 13, 2026 03:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds profiling and tracing configuration flags (enable_pphlo_profile, enable_hal_profile, enable_pphlo_trace, and enable_action_trace) to SPUConfig and propagates them to the SPU runtime configuration. It also updates the runtime caching mechanism to include these flags in the cache key so that different profiling configurations generate distinct runtimes while reusing the same template link. The feedback suggests handling None values defensively in the _parse_bool helper to avoid unexpected runtime crashes, and simplifying the dictionary retrieval in SPUConfig.from_dict using a more idiomatic Python pattern.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread mplang/dialects/spu.py
Comment thread mplang/dialects/spu.py

@danqi437 danqi437 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FollyCoolly
FollyCoolly merged commit 2942b93 into main Jul 13, 2026
11 of 12 checks passed
@FollyCoolly
FollyCoolly deleted the zhsu/spu-profiling branch July 13, 2026 03:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants