feat: support SPU profiling config - #420
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds profiling and tracing configuration flags (enable_pphlo_profile, enable_hal_profile, enable_pphlo_trace, and enable_action_trace) to SPUConfig and propagates them to the SPU runtime configuration. It also updates the runtime caching mechanism to include these flags in the cache key so that different profiling configurations generate distinct runtimes while reusing the same template link. The feedback suggests handling None values defensively in the _parse_bool helper to avoid unexpected runtime crashes, and simplifying the dictionary retrieval in SPUConfig.from_dict using a more idiomatic Python pattern.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.