refactor(table): remove TableSource abstraction, materialize to pa.Ta… - #423
Merged
Conversation
…ble eagerly The store.save path pickles its argument directly via FileSystemBackend.put. When the value was a TableValue returned by run_sql, its _data was a QueryTableSource holding a live DuckDBPyRelation + DuckDBPyConnection, neither picklable — so save aborted with "cannot pickle 'DuckDBPyRelation' object". Remove the lazy TableSource abstraction so TableValue._data is always a picklable pa.Table and store.save persists real results: - Drop TableSource, FileTableSource, QueryTableSource, DuckDBState, ParquetReader and the #422 DuckDB-CAST helpers - run_sql_impl: fresh DuckDB conn per call, register pa.Table inputs, materialize the result via fetch_arrow_table() - read_impl: read files straight into pa.Table, enforcing declared schema at read time (parse-time column_types for CSV, post-read cast otherwise) - write_impl: drop the TableSource branch; inputs are always pa.Table - Simplify TableValue to WrapValue[pa.Table] (no lazy materialization) Tradeoff: file reads now load fully into memory; DuckDB connections are no longer reused across run_sql calls.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
oeqqwq
reviewed
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ble eagerly
The store.save path pickles its argument directly via FileSystemBackend.put. When the value was a TableValue returned by run_sql, its _data was a QueryTableSource holding a live DuckDBPyRelation + DuckDBPyConnection, neither picklable — so save aborted with "cannot pickle 'DuckDBPyRelation' object".
Remove the lazy TableSource abstraction so TableValue._data is always a picklable pa.Table and store.save persists real results:
Tradeoff: file reads now load fully into memory; DuckDB connections are no longer reused across run_sql calls.