Skip to content

fix(examples): relocate the broken dev-path demos to wip/ + drop the denylist (UX Ph6 F1) - #223

Merged
jeffcrouse merged 1 commit into
mainfrom
fix-ph6f1-relocate-wip-demos
Aug 2, 2026
Merged

fix(examples): relocate the broken dev-path demos to wip/ + drop the denylist (UX Ph6 F1)#223
jeffcrouse merged 1 commit into
mainfrom
fix-ph6f1-relocate-wip-demos

Conversation

@jeffcrouse

Copy link
Copy Markdown
Member

What & why

Closes the last post-release UX backlog item, Ph6 F1. The six dev-path demos (bloom/chop/drift/grid/mirror/signal) were excluded from the shipped bundle by a CMake denylist (#214) but still lived in examples/demos/projects/ referencing media that either isn't bundled or can't legally ship. They're now relocated to examples/demos/wip/ so projects/ holds only curated, self-contained demos, and the denylist is gone.

The licensing reality (why relocate, not repair)

Repairing-and-shipping is blocked for 4 of 6:

  • drift, grid — depend on a personal, non-redistributable Ableton sample library (~/Music/Ableton/.../Dan Mayo/...).
  • signal — uses a 3D model licensed CC-BY-NC-SA-4.0 (non-commercial) → can't ship in the product.
  • chop — a dev-repo .wav of unverified license.
  • bloom, mirror — reference a title-text file by absolute path; trivially fixable but low-value (bloom is a near-static loop).

Only bloom is committed (git rename to wip/). The other five stay uncommitted on purpose — their assets must not enter the repo. wip/README.md documents each blocker and the path to reviving one.

Latent bug also fixed

The denylist was masking a real bug: the copy target used copy_directory, which merges into the destination — so a demo removed from projects/ would linger in a rebuilt bundle (I hit exactly this: all six reappeared). The target now rms the destination first, mirroring projects/ faithfully.

Verification

  • examples/demos/projects/ = the 12 shippable demos, every media ref project-relative (checked all).
  • A rebuild copies exactly those 12 into Vivid.app/…/Resources/examples/ — none of the six (verified before/after the rm fix).
  • No stale code/test references to the moved demos.

🤖 Generated with Claude Code

…denylist (UX Ph6 F1)

The six dev-path demos (bloom/chop/drift/grid/mirror/signal) were excluded from
the shipped bundle by a CMake denylist (PR #214) but still sat in
examples/demos/projects/ referencing media that either isn't bundled or can't
legally ship. Move them to examples/demos/wip/ so projects/ holds only curated,
self-contained demos, and drop the denylist.

Only bloom is committed (its media is a stale-worktree title-text ref). The other
five stay UNCOMMITTED on purpose — drift/grid depend on a personal,
non-redistributable Ableton sample library, and signal's 3D model is CC-BY-NC-SA
(non-commercial) — so they cannot be committed or shipped as-is. wip/README.md
documents each blocker and how to revive one.

Also fixes a latent bundling bug the denylist was masking: the copy target used
copy_directory, which MERGES into the destination, so a demo removed from
projects/ would linger in a rebuilt bundle. The target now rm's the destination
first, mirroring projects/ faithfully.

Verified: examples/demos/projects/ = the 12 shippable demos (all media
project-relative); a rebuild copies exactly those into the app bundle, none of
the six.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QB6eSNJE55ru3g4vsL77GT
@jeffcrouse
jeffcrouse enabled auto-merge (squash) August 2, 2026 02:07
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Production gate (core): ✅ PASS

  • 66/66 tests passed (0 failed) in 12.711s

@jeffcrouse
jeffcrouse merged commit 918c102 into main Aug 2, 2026
8 checks passed
@jeffcrouse
jeffcrouse deleted the fix-ph6f1-relocate-wip-demos branch August 2, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant