Share recipe access: Feature #52 - #58
Merged
Merged
Conversation
utricularian
force-pushed
the
codex/rpi-52-shared-recipes
branch
7 times, most recently
from
August 9, 2026 15:28
7f120da to
804c406
Compare
utricularian
force-pushed
the
codex/rpi-52-shared-recipes
branch
2 times, most recently
from
August 10, 2026 14:10
14629bf to
04a1222
Compare
utricularian
force-pushed
the
codex/rpi-52-shared-recipes
branch
from
August 10, 2026 14:12
04a1222 to
d8c4b82
Compare
Feature #52 Implements: - #54 Validation: - Ruby syntax, RuboCop, routes, bundle check, importmap audit, and git diff --check pass. - PostgreSQL-backed tests and migration validation require an unavailable PostgreSQL environment. - Brakeman and bundler-audit retain pre-existing findings outside this task.
Feature #52 Implements: - #55 Validation: - Shared UI wording probe, Ruby/ERB syntax, targeted RuboCop, routes, bundle check, importmap audit, and git diff --check pass. - PostgreSQL-backed unit/integration and system tests require an unavailable local PostgreSQL environment. - Brakeman retains the inherited XSS warning and bundler-audit retains inherited dependency advisories.
utricularian
force-pushed
the
codex/rpi-52-shared-recipes
branch
from
August 10, 2026 14:18
d8c4b82 to
472582f
Compare
Remove the duplicate index reference URL tests introduced by the shared-workflow UI commit so RecipesControllerTest can load once per test name.
utricularian
marked this pull request as ready for review
August 10, 2026 14:42
utricularian
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Feature #52
Implements:
Current stack
Tasks #53, #54, and #55 are implemented on the shared branch. The final task removes remaining personal recipe wording, preserves the anonymous recipe workflow UI, and adds shared wording plus request-level CSRF and flash coverage.
Validation
recipes#indexand legacy auth routes are absent.git diff --check: passed.test,system-test,lint, andscan_js: passed on task Shared-Workflow UI And Regression Coverage #55 head.scan_ruby: fails on inherited weak XSS warning inapp/views/recipes/show.html.erb:19.Stack
maincodex/rpi-52-shared-recipesReview status
The shared PR remains draft. Do not mark ready while inherited Brakeman/XSS and bundler-audit findings remain unresolved.