Make smallgrp an explicit dependency - #1206
Open
fingolfin wants to merge 1 commit into
Open
Conversation
SEMIGROUPS_ProcessRandomArgsCons for IsReesMatrixSemigroup picks a random
group when the caller does not supply one, using NumberSmallGroups and
SmallGroup. Without the SmallGrp package this fails, e.g. in a GAP
started with `--bare':
gap> RandomSemigroup(IsReesMatrixSemigroup);;
Error, Variable: 'NumberSmallGroups' must have an assigned value
This is the only place in Semigroups using the small groups library.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
BTW the current function would also run into an error if it happened to produce Also, if the goal was to select small groups uniformly, that is of course also not the case. But I assume you are aware, just wanted to mention it for completeness sake :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SEMIGROUPS_ProcessRandomArgsCons for IsReesMatrixSemigroup picks a random group when the caller does not supply one, using NumberSmallGroups and SmallGroup. Without the SmallGrp package this fails, e.g. in a GAP started with `--bare':
This is the only place in Semigroups using the small groups library.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Of course you could also rework the code to not use SmallGrp, that'd be perfectly cromulent :-)